From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932161AbbBZSwK (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Feb 2015 13:52:10 -0500
Received: from galahad.ideasonboard.com ([185.26.127.97]:53121 "EHLO
	galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752870AbbBZSwI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Feb 2015 13:52:08 -0500
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Felipe Balbi <balbi@ti.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] usb: isp1760: add peripheral/device controller chip id
Date: Thu, 26 Feb 2015 20:53:14 +0200
Message-ID: <9376982.frUB33IUZX@avalon>
User-Agent: KMail/4.14.3 (Linux/3.18.7-gentoo; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1424951277-13375-1-git-send-email-sudeep.holla@arm.com>
References: <1424800422-25332-1-git-send-email-sudeep.holla@arm.com> <1424951277-13375-1-git-send-email-sudeep.holla@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sudeep,

Thank you for the patch.

On Thursday 26 February 2015 11:47:57 Sudeep Holla wrote:
> As per the SAF1761 data sheet[0], the DcChipID register represents
> the hardware version number (0001h) and the chip ID (1582h) for the
> Peripheral Controller.
> 
> However as per the ISP1761 data sheet[1], the DcChipID register
> represents the hardware version number (0015h) and the chip ID (8210h)
> for the Peripheral Controller.
> 
> This patch adds support for both the chip ID values.
> 
> [0] http://www.nxp.com/documents/data_sheet/SAF1761.pdf
> [1] http://pdf.datasheetcatalog.com/datasheets2/74/742102_1.pdf
> 
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/usb/isp1760/isp1760-udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Changes v1->v2:
>  - Updated to support both chip IDs: 0x00011582 and 0x00158210 instead of
>    just 0x00158210 as suggested by Laurent
> 
> diff --git a/drivers/usb/isp1760/isp1760-udc.c
> b/drivers/usb/isp1760/isp1760-udc.c index 9612d7990565..6d618b3fab07 100644
> --- a/drivers/usb/isp1760/isp1760-udc.c
> +++ b/drivers/usb/isp1760/isp1760-udc.c
> @@ -1411,7 +1411,7 @@ static int isp1760_udc_init(struct isp1760_udc *udc)
>  		return -ENODEV;
>  	}
> 
> -	if (chipid != 0x00011582) {
> +	if (chipid != 0x00011582 && chipid != 0x00158210) {
>  		dev_err(udc->isp->dev, "udc: invalid chip ID 0x%08x\n", chipid);
>  		return -ENODEV;
>  	}

-- 
Regards,

Laurent Pinchart