From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F7F93CD8BD for ; Tue, 28 Apr 2026 08:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365373; cv=none; b=Z9MzbYVlRuM2rOU/5GA60nHpMFxQz5lzg1FKamePeat12iSbx5AWW3XbZXklYiu812/V5KheKkXh2nOrvyOZFsm+Qq8rxq5c0OnX5X7iZenObPfzjELb8OYcjisw9SxkbjQw4t7FuL5hzBLKMHS+f1lMLWMGMW1xUcDlOOi7DAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777365373; c=relaxed/simple; bh=3sAZLj0NLRiBxjN5SeUiDy9R29dqmYOqD3dBKY9fk04=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jgwiUftFf/54ZlSYrCLluW/HEPv5+pAMbI2M5cQ7xp1QgiwMZbQNg7uHDFefnLl3ZZuRs43+c7jTSA6+erqOdDUw/a0mf/ppsoiVu+e19jQlghpaiO9xK3BU2oNwCeGf/dFbcLvi3LNxwp2VZwOPKnXAVdbJ8SMvn8kNlHrPb/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=bBgekiLt; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="bBgekiLt" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488b8bc6bc9so80044405e9.3 for ; Tue, 28 Apr 2026 01:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1777365370; x=1777970170; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pCY+zuQyx9GlGlpOXTysGsnBwr93z9Zdc4O6jTMzbYk=; b=bBgekiLtlNIgO/uCzySqThVdaTvILGe4k3go8VQM6JEZMTFV4ns2aEZLHYv/sFR8ng dnv6UkyYmUksewXBVzrfW2ulxHaCZU3vQQ1fN8G/XYz0wq1QxvNYB5XFAoGD7VqpB+pE zG3KzmjIRrd+Y87jltAdvHW7gRKeeEvLuiGBt3guJdGY2Aa7HH9N5Rab8Ci0yApBbSCb M/x6V7iOGjfgH1t2BKGbVfaGXibLSZGJO/ILdwbQcYBXiQirp9EwaIpd7J/IwxYQ9Dlx Krn8pYpqHqPDBycxitQvHRT1lhYZtLqW65I+EZ9n/Fke86+/8CHC0EWdjl7lB23LnGU2 gZ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777365370; x=1777970170; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pCY+zuQyx9GlGlpOXTysGsnBwr93z9Zdc4O6jTMzbYk=; b=I2d5bPEJ9ZP2N6A/ktF8qM478ayrZaoEwh3EWtfSE/7+jVabyktKme8eyfumu4SKLK 2BUGVi7OHvYLILLxbQF/fY1PG3Gf3XzdpFy6irKIlulQNd39BKImlttaMxzychPlw/D3 JaUS0tg/4wqiqHLh4BdUCLm9s8/6Igl2RpG932U07M1vLl2bxTAeiHSTHsTtU2ctfn2m 7jC00yRXFETTyNjPq5o8nm/zUiqFxVEUHMfjmG4DXld/go716xUSkSSdw3E7OH2LiVBp vxLD4hgsCyruBzW8UKYqJ73nCpKejsFKO6/TS+i9mC+R82kpbPTqL8MZW9u+PtkVW41f RCMg== X-Forwarded-Encrypted: i=1; AFNElJ+hYYDT+8+CrAYAGo5Hp3zZ8/oxN2zdsHyplOtUZIF90DO/Uu++zMFI+rjTx9a6fHXMN1IcXA/prZo7Isc=@vger.kernel.org X-Gm-Message-State: AOJu0YymBym+/svMnDapVdxYLFCLMAoblGUDovwHIWKNQknMGViEtRA2 zwZkUEvLc6t7jDfYJLG2MqZw2NwkCClLquRIU7z1eSNClvXT9ZMdm8uvzVRYXEHjtos= X-Gm-Gg: AeBDiesWUirtkgDbYxkxSS43FoOa198Z7dG4G6kMJi13xENIFnx9YiJfIhus7n1r0vC Q9fZ73O7QElW01hS6JtNQgFYxx5GEZ8qXazuRADN8erXhKBuX/E2+/Z8d1drpeUYm79ghDE+XFk 2sm0KkVDx5jNMZAVbKvOTadv30axnH/ukTX81k40qSpr01OIMhL21CM28Yv63/blAIPFb28Dqsn TtBPgKeENPbkZ1JrXRyO2mGbGad4xwwNsOCrCandgy/hFLK3pAvMF+7lOn3MoK+Nlam3+FIKkAO prVSS73z/aTijoB4FWOsYVVOr/1BlYupRk4fHduwRYttxSjD6lXfM/CK85u0yQTVegZD6/xgVOr ZO6XomsluBJ4QHLiZ3iSODJycqjCrQwE/cOoi+6KBNiINSWhKuN7mi2BCAuih2fqaljOKPb/Ggi 2AN5Q/plgvL02sQWhGhJ3zwUJsXPFw9rFNepup0hIv9m/mAfnvw7BeTn3sR9b0HX2+5XxPh42ic g== X-Received: by 2002:a05:600c:83c3:b0:488:ab1d:dcc5 with SMTP id 5b1f17b1804b1-48a77b1e8c6mr34320375e9.27.1777365370542; Tue, 28 Apr 2026 01:36:10 -0700 (PDT) Received: from ?IPV6:2001:a61:1399:ff01:bd7:b9d5:f4ba:1161? ([2001:a61:1399:ff01:bd7:b9d5:f4ba:1161]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a775fd14csm13875935e9.31.2026.04.28.01.36.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 01:36:09 -0700 (PDT) Message-ID: <937aca8d-805b-418e-a2ed-58c1e38f45e7@suse.com> Date: Tue, 28 Apr 2026 10:36:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] media: uvcvideo: skip resume when writing hibernation image To: Haowen Tu , rafael@kernel.org Cc: lenb@kernel.org, pavel@kernel.org, linux-pm@vger.kernel.org, laurent.pinchart@ideasonboard.com, hansg@kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260428080513.1833515-1-tuhaowen@uniontech.com> <20260428080513.1833515-3-tuhaowen@uniontech.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20260428080513.1833515-3-tuhaowen@uniontech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 28.04.26 10:05, Haowen Tu wrote: > Skipping the THAW resume is safe: stream->frozen remains 1 (set during > the earlier FREEZE suspend), the device is powered off immediately after > swsusp_write() with no intervening suspend, and the subsequent > PMSG_RESTORE resume on the restored kernel calls uvc_video_resume() > with pm_hibernation_storing_image() returning false, performing the full > reinitialization as normal. > What happens if writing out the image fails? Regards Oliver