From: Heiko Stuebner <heiko@sntech.de>
To: Andy Yan <andy.yan@rock-chips.com>
Cc: devicetree@vger.kernel.org, briannorris@chromium.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board
Date: Sat, 10 Sep 2016 11:15:29 +0200 [thread overview]
Message-ID: <9389291.9daRDJEYck@phil> (raw)
In-Reply-To: <1473498094-16279-1-git-send-email-andy.yan@rock-chips.com>
Hi Andy,
Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
> PX3 board is designed by Rockchip for automotive field,
> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
> video input/output interface, WIFI/BT/GPS(on a module
> named S500 which based on MT6620), Gsensor BMA250E and
> light&proximity sensor STK3410.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
>
> Documentation/devicetree/bindings/arm/rockchip.txt | 4 +
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/rk3188-px3.dts | 337
> +++++++++++++++++++++ 3 files changed, 342 insertions(+)
> create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
> b/Documentation/devicetree/bindings/arm/rockchip.txt index 6668645..e680105
> 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
> Required root node properties:
> - compatible = "radxa,rock", "rockchip,rk3188";
>
> +- Rockchip PX3 board:
> + Required root node properties:
> + - compatible = "rockchip,px3", "rockchip,rk3188";
Just like to confirm the naming.
I read the announcement of both the PX3 and PX5 socs, are the boards really
also named only px3 + px5 - same as the socs they carry, or are they more
likely to be called px3-evb or similar?
The dts themself look fine on first glance.
Thanks
Heiko
next prev parent reply other threads:[~2016-09-10 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 9:01 [PATCH 1/2] ARM: dts: add rockchip PX3 board Andy Yan
2016-09-10 9:05 ` [PATCH 2/2] arm64: dts: rockchip: Add PX5 board Andy Yan
2016-09-10 9:15 ` Heiko Stuebner [this message]
2016-09-10 9:37 ` [PATCH 1/2] ARM: dts: add rockchip PX3 board Andy Yan
2016-09-10 9:45 ` Heiko Stuebner
2016-09-10 9:46 ` Andy Yan
2016-09-10 10:03 ` Heiko Stuebner
2016-09-10 10:07 ` Heiko Stuebner
[not found] ` <201609102110352938974@rock-chips.com>
2016-09-10 13:27 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9389291.9daRDJEYck@phil \
--to=heiko@sntech.de \
--cc=andy.yan@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox