From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754495AbcIJJPm (ORCPT ); Sat, 10 Sep 2016 05:15:42 -0400 Received: from gloria.sntech.de ([95.129.55.99]:56406 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830AbcIJJPl (ORCPT ); Sat, 10 Sep 2016 05:15:41 -0400 From: Heiko Stuebner To: Andy Yan Cc: devicetree@vger.kernel.org, briannorris@chromium.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Subject: Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board Date: Sat, 10 Sep 2016 11:15:29 +0200 Message-ID: <9389291.9daRDJEYck@phil> User-Agent: KMail/5.2.3 (Linux/4.6.0-1-amd64; KDE/5.25.0; x86_64; ; ) In-Reply-To: <1473498094-16279-1-git-send-email-andy.yan@rock-chips.com> References: <1473498094-16279-1-git-send-email-andy.yan@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan: > PX3 board is designed by Rockchip for automotive field, > which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI > video input/output interface, WIFI/BT/GPS(on a module > named S500 which based on MT6620), Gsensor BMA250E and > light&proximity sensor STK3410. > > Signed-off-by: Andy Yan > --- > > Documentation/devicetree/bindings/arm/rockchip.txt | 4 + > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/rk3188-px3.dts | 337 > +++++++++++++++++++++ 3 files changed, 342 insertions(+) > create mode 100644 arch/arm/boot/dts/rk3188-px3.dts > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt > b/Documentation/devicetree/bindings/arm/rockchip.txt index 6668645..e680105 > 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.txt > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt > @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings > Required root node properties: > - compatible = "radxa,rock", "rockchip,rk3188"; > > +- Rockchip PX3 board: > + Required root node properties: > + - compatible = "rockchip,px3", "rockchip,rk3188"; Just like to confirm the naming. I read the announcement of both the PX3 and PX5 socs, are the boards really also named only px3 + px5 - same as the socs they carry, or are they more likely to be called px3-evb or similar? The dts themself look fine on first glance. Thanks Heiko