Re: [PATCH] hashed device lookup (Does NOT meet Linus' sumission

Ben Greear
2001-01-07T18:07:12Z

Alan Cox wrote:
>
> > Suppose I bind a raw socket to device vlan4001 (ie I have 4k in the list
> > before that one!!). Currently, that means a linear search on all devices,
> > right? In that extreme example, I would expect the hash to be very
> > useful.
>
> At this point you have to ask 'why is vlan4001 an interface'. Would it not
> be cleaner to add the vlan id to the entries in the list of addresses per
> interface ?

Among other things, some VLAN switches won't work unless you can change
the MAC address on your VLANs to be different from the rest of the
VLAN MACs on that physical interface. For OSPF you also need to
have multicast work on them, and other things that look very much like
a real interface.

Also, by making the VLANs a net_device, the rest of the kernel and
user-space code (ip, ifconfig, for example), works as expected, with
no changes.

--
Ben Greear (greearb@candelatech.com) http://www.candelatech.com
Author of ScryMUD: scry.wanfear.com 4444 (Released under GPL)
http://scry.wanfear.com http://scry.wanfear.com/~greear