public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: John Meneghini <jmeneghi@redhat.com>,
	Hannes Reinecke <hare@suse.de>,
	Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	"emilne@redhat.com" <emilne@redhat.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
	"kbusch@kernel.org" <kbusch@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"jrani@purestorage.com" <jrani@purestorage.com>,
	"randyj@purestorage.com" <randyj@purestorage.com>,
	"hare@kernel.org" <hare@kernel.org>
Subject: Re: [PATCH v5] nvme: multipath: Implemented new iopolicy "queue-depth"
Date: Thu, 23 May 2024 19:33:38 +0000	[thread overview]
Message-ID: <93b0f8fc-e6d4-48a6-8790-a9e7cf649b63@nvidia.com> (raw)
In-Reply-To: <4d90d565-c156-4e4c-8a16-f32aa73fc809@redhat.com>

On 5/23/24 7:42 AM, John Meneghini wrote:
>
> On 5/23/24 02:28, Hannes Reinecke wrote:
>> As presented at LSF by Daniel; ALUA support (and, with that, 
>> multipath support) is one of the topics to be implemented for blktests.
>> And without that we can't have a meaningful QD test.
>
> So as a part of this patch you want a blktest that verifies 
> queue-depth multipathing?
>
> Or are your just tying acceptance of this patch to a blktest that 
> tests multipath testing over all?
>

as I mentioned this earlier having a blktest is not a blocker for 
acceptance of this patch at all

once this patch is merged it'd be nice to have it, but you have to wait 
for Daniel's ALUA support
as mentioned by Hannes in previous email ...


> Seems to me you have a patch designed to do that...
>
> https://github.com/osandov/blktests/pull/114
>
> /John

-ck





  reply	other threads:[~2024-05-23 19:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 16:54 [PATCH v5] nvme: multipath: Implemented new iopolicy "queue-depth" John Meneghini
2024-05-22 17:32 ` Keith Busch
2024-05-23  6:45   ` Christoph Hellwig
2024-05-23 13:12     ` John Meneghini
2024-05-23 13:16       ` Christoph Hellwig
2024-05-23 13:33         ` John Meneghini
2024-05-23 15:56       ` Keith Busch
2024-05-23  3:00 ` John Meneghini
2024-05-23  4:29 ` Chaitanya Kulkarni
2024-05-23  6:28   ` Hannes Reinecke
2024-05-23 13:42     ` John Meneghini
2024-05-23 19:33       ` Chaitanya Kulkarni [this message]
2024-05-23 19:28     ` Chaitanya Kulkarni
2024-05-23  6:52 ` Christoph Hellwig
2024-05-23 15:08   ` John Meneghini
2024-05-23  8:14 ` Christoph Hellwig
2024-05-23 16:07   ` John Meneghini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93b0f8fc-e6d4-48a6-8790-a9e7cf649b63@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=emilne@redhat.com \
    --cc=hare@kernel.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jmeneghi@redhat.com \
    --cc=jrani@purestorage.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=randyj@purestorage.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox