From: "Moger, Babu" <bmoger@amd.com>
To: "Luck, Tony" <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Chatre, Reinette" <reinette.chatre@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
D Scott Phillips OS <scott@os.amperecomputing.com>,
"carl@os.amperecomputing.com" <carl@os.amperecomputing.com>,
"lcherian@marvell.com" <lcherian@marvell.com>,
"bobo.shaobowang@huawei.com" <bobo.shaobowang@huawei.com>,
"tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>,
"baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
Jamie Iles <quic_jiles@quicinc.com>,
Xin Hao <xhao@linux.alibaba.com>,
"peternewman@google.com" <peternewman@google.com>,
"dfustini@baylibre.com" <dfustini@baylibre.com>,
"amitsinght@marvell.com" <amitsinght@marvell.com>,
David Hildenbrand <david@redhat.com>,
Rex Nie <rex.nie@jaguarmicro.com>,
Dave Martin <dave.martin@arm.com>, "Ko, Koba" <kobak@nvidia.com>,
Shanker Donthineni <sdonthineni@nvidia.com>,
"fenghuay@nvidia.com" <fenghuay@nvidia.com>
Subject: Re: RE: [PATCH v8 08/21] x86/resctrl: Expand the width of dom_id by replacing mon_data_bits
Date: Tue, 22 Apr 2025 12:59:31 -0500 [thread overview]
Message-ID: <93da0002-a326-49f2-af5d-f89da9d3a8f6@amd.com> (raw)
In-Reply-To: <DS7PR11MB6077A729E4338E6C62939005FCBB2@DS7PR11MB6077.namprd11.prod.outlook.com>
Hi Tony,
On 4/22/2025 12:14 PM, Luck, Tony wrote:
>> Do we really need to maintain a separate list for all the private pointers?
>>
>> Here's my understanding of the patch—please correct me if I’m missing
>> anything:
>>
>> Patch Requirements:
>>
>> 1. Expand dom_id.
>>
>> 2. Pack all necessary data (dom_id, event_id, resid) into the
>> of->kn->priv pointer when creating event files in the mon_data
>> directory for each domain.
>
> This step includes searching the list of previously created priv structures
> to find a matching one that can be shared. This happens all the time
> because the same set of values is re-used over and over. Essentially
> we only allocate anything while creating the mon_data directory in the
> root directory of resctrl. James' original implementation made use of
> this by special case allocation for the default group, and then doing
> kernfs lookups while creating new groups to find the matching one
> and linking to the same ->priv pointer.
>
oh ok.
I went back and looked at the history.
https://lore.kernel.org/all/20250228195913.24895-38-james.morse@arm.com/
So you are saying, kernfs lookup method is much more complex. So, having
the global list is easy to traverse and efficient?
Thanks
Babu
next prev parent reply other threads:[~2025-04-22 17:59 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 16:42 [PATCH v8 00/21] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl James Morse
2025-04-11 16:42 ` [PATCH v8 01/21] x86/resctrl: Fix rdtgroup_mkdir()'s unlocked use of kernfs_node::name James Morse
2025-04-12 0:10 ` Fenghua Yu
2025-04-11 16:42 ` [PATCH v8 02/21] x86/resctrl: Remove the limit on the number of CLOSID James Morse
2025-04-15 21:06 ` Reinette Chatre
2025-04-24 9:12 ` James Morse
2025-04-24 15:17 ` Reinette Chatre
2025-04-25 2:56 ` Shaopeng Tan (Fujitsu)
2025-04-25 15:56 ` James Morse
2025-04-11 16:42 ` [PATCH v8 03/21] x86/resctrl: Rename resctrl_sched_in() to begin with "resctrl_arch_" James Morse
2025-04-15 21:11 ` Reinette Chatre
2025-04-24 9:12 ` James Morse
2025-04-11 16:42 ` [PATCH v8 04/21] x86/resctrl: resctrl_exit() teardown resctrl but leave the mount point James Morse
2025-04-16 0:25 ` Reinette Chatre
2025-04-24 9:15 ` James Morse
2025-04-11 16:42 ` [PATCH v8 05/21] x86/resctrl: Drop __init/__exit on assorted symbols James Morse
2025-04-11 16:42 ` [PATCH v8 06/21] x86/resctrl: Move is_mba_sc() out of core.c James Morse
2025-04-11 16:42 ` [PATCH v8 07/21] x86/resctrl: Add end-marker to the resctrl_event_id enum James Morse
2025-04-15 18:56 ` Luck, Tony
2025-04-24 9:15 ` James Morse
2025-04-11 16:42 ` [PATCH v8 08/21] x86/resctrl: Expand the width of dom_id by replacing mon_data_bits James Morse
2025-04-16 0:34 ` Reinette Chatre
2025-04-24 11:15 ` James Morse
2025-04-22 17:06 ` Moger, Babu
2025-04-22 17:14 ` Luck, Tony
2025-04-22 17:59 ` Moger, Babu [this message]
2025-04-22 18:10 ` Luck, Tony
2025-04-11 16:42 ` [PATCH v8 09/21] x86/resctrl: Remove a newline to avoid confusing the code move script James Morse
2025-04-25 2:32 ` Shaopeng Tan (Fujitsu)
2025-04-25 15:59 ` James Morse
2025-04-11 16:42 ` [PATCH v8 10/21] x86/resctrl: Split trace.h James Morse
2025-04-11 16:42 ` [PATCH v8 11/21] fs/resctrl: Add boiler plate for external resctrl code James Morse
2025-04-11 16:42 ` [PATCH v8 12/21] x86/resctrl: Move the filesystem bits to headers visible to fs/resctrl James Morse
2025-04-17 22:46 ` Reinette Chatre
2025-04-24 9:25 ` James Morse
2025-04-11 16:42 ` [PATCH v8 13/21] x86/resctrl: Squelch whitespace anomalies in resctrl core code James Morse
2025-04-11 16:42 ` [PATCH v8 14/21] x86/resctrl: Prefer alloc(sizeof(*foo)) idiom in rdt_init_fs_context() James Morse
2025-04-11 16:42 ` [PATCH v8 15/21] x86/resctrl: Relax some asm #includes James Morse
2025-04-16 2:08 ` Reinette Chatre
2025-04-11 16:42 ` [PATCH v8 16/21] x86/resctrl: Always initialise rid field in rdt_resources_all[] James Morse
2025-04-15 19:08 ` Luck, Tony
2025-04-24 17:08 ` James Morse
2025-04-16 2:14 ` Reinette Chatre
2025-04-24 17:08 ` James Morse
2025-04-11 16:42 ` [PATCH v8 17/21] x86,fs/resctrl: Move the resctrl filesystem code to live in /fs/resctrl James Morse
2025-04-12 0:18 ` Fenghua Yu
2025-04-14 16:04 ` Reinette Chatre
2025-04-14 23:22 ` Fenghua Yu
2025-04-14 23:29 ` Reinette Chatre
2025-04-14 23:21 ` Fenghua Yu
2025-04-24 17:08 ` James Morse
2025-04-15 0:27 ` Fenghua Yu
2025-04-24 17:11 ` James Morse
2025-04-11 16:42 ` [PATCH v8 18/21] x86,fs/resctrl: Remove duplicated trace header files James Morse
2025-04-16 2:18 ` Reinette Chatre
2025-04-24 17:11 ` James Morse
2025-04-22 14:23 ` Fenghua Yu
2025-04-24 17:11 ` James Morse
2025-04-11 16:42 ` [PATCH v8 19/21] fs/resctrl: Remove unnecessary includes James Morse
2025-04-11 16:42 ` [PATCH v8 20/21] fs/resctrl: Change internal.h's header guard macros James Morse
2025-04-11 16:42 ` [PATCH v8 21/21] x86,fs/resctrl: Move resctrl.rst to live under Documentation/filesystems James Morse
2025-04-16 2:31 ` Reinette Chatre
2025-04-24 17:12 ` James Morse
2025-04-24 17:22 ` Reinette Chatre
2025-04-15 18:48 ` [PATCH v8 00/21] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl Luck, Tony
2025-04-24 17:12 ` James Morse
2025-04-17 12:18 ` Shaopeng Tan (Fujitsu)
2025-04-17 14:47 ` Reinette Chatre
2025-04-18 0:08 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93da0002-a326-49f2-af5d-f89da9d3a8f6@amd.com \
--to=bmoger@amd.com \
--cc=Babu.Moger@amd.com \
--cc=amitsinght@marvell.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bobo.shaobowang@huawei.com \
--cc=bp@alien8.de \
--cc=carl@os.amperecomputing.com \
--cc=dave.martin@arm.com \
--cc=david@redhat.com \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=kobak@nvidia.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peternewman@google.com \
--cc=quic_jiles@quicinc.com \
--cc=reinette.chatre@intel.com \
--cc=rex.nie@jaguarmicro.com \
--cc=scott@os.amperecomputing.com \
--cc=sdonthineni@nvidia.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=tan.shaopeng@fujitsu.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xhao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox