Re: REGRESSION: no console on current -git

Helge Deller
2024-01-19T21:14:54Z

On 1/19/24 22:01, Jens Axboe wrote:
> On 1/19/24 1:55 PM, Helge Deller wrote:
>> Adding Mirsad Todorovac (who reported a similar issue).
>>
>> On 1/19/24 19:39, Jens Axboe wrote:
>>> My trusty R7525 test box is failing to show a console, or in fact anything,
>>> on current -git. There's no output after:
>>>
>>> Loading Linux 6.7.0+ ...
>>> Loading initial ramdisk ...
>>>
>>> and I don't get a console up. I went through the bisection pain and
>>> found this was the culprit:
>>>
>>> commit df67699c9cb0ceb70f6cc60630ca938c06773eda
>>> Author: Thomas Zimmermann <tzimmermann@suse.de>
>>> Date: Wed Jan 3 11:15:11 2024 +0100
>>>
>>> firmware/sysfb: Clear screen_info state after consuming it
>>>
>>> Reverting this commit, and everything is fine. Looking at dmesg with a
>>> buggy kernel, I get no frame or fb messages. On a good kernel, it looks
>>> ilke this:
>>>
>>> [ 1.416486] efifb: probing for efifb
>>> [ 1.416602] efifb: framebuffer at 0xde000000, using 3072k, total 3072k
>>> [ 1.416605] efifb: mode is 1024x768x32, linelength=4096, pages=1
>>> [ 1.416607] efifb: scrolling: redraw
>>> [ 1.416608] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
>>> [ 1.449746] fb0: EFI VGA frame buffer device
>>>
>>> Happy to test a fix, or barring that, can someone just revert this
>>> commit please?
>>
>> I've temporarily added a revert patch into the fbdev for-next tree for now,
>> so people should not face the issue in the for-next series:
>> https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git/commit/?h=for-next
>> I'd like to wait for Thomas to return on monday to check the issue
>> as there are some other upcoming patches in this area from him.
>
> Given the issue (and that I'm not the only one reporting it), can we
> please just get that pushed so it'll make -rc1? It can always get
> re-introduced in a fixed fashion. I don't run -next here, I rely on
> mainline working for my testing.

I agree, it would be good to get it fixed for -rc1.
So, it's ok for me, but I won't be able to test the revert short time right now.
If you can assure that the revert fixes it, and builds in git-head,
I can now prepare the pull request for Linus now (or he just reverts
commit df67699c9cb0 manually).

Helge