From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752092AbcFUPiJ (ORCPT ); Tue, 21 Jun 2016 11:38:09 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:61827 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbcFUPhw (ORCPT ); Tue, 21 Jun 2016 11:37:52 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Ben Dooks , linux-kernel@lists.codethink.co.uk, Andrew Lunn , Jason Cooper , linux-kernel@vger.kernel.org, Evan Wang , Gregory CLEMENT Subject: Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static Date: Tue, 21 Jun 2016 17:31:13 +0200 Message-ID: <9446011.bTD6e4eDRY@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1466522179-22198-2-git-send-email-ben.dooks@codethink.co.uk> References: <1466522179-22198-1-git-send-email-ben.dooks@codethink.co.uk> <1466522179-22198-2-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ZEN4HkzTGHDfSY+3J0CB3fRE6hjE8T2+uWkGPL6QEpgarJBQevV UPYLekMBH9t/U+jYb5Zqzq0k5Tx76PcGZfGHQhxam9EiC614bUsnG4OQ0Gv2lkosa+jYhvU ABt/GL4uEaad5habDfXBIzRrNApu0GinITUtclWJnfweAovYqqtnhh9ZVOQIsVc43RWf8Of 7zLew6B7tNSWufEGpcLgQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:cDvzl4fdqfc=:uraN2Uyc66jF3PgzScGuuL 70Wbrd86xlOh4ilsRr0elum85hP9DvkPQJFd16+V3INvskCQxu3dYZESgxtMPVfNYC5t+3u+i QAM4e0jhy9SsavUK2PmowLQaokXP4khGmcBLA60K52MtfYg3uTZo+OqZcxpFQWtgBJoBB/mhD 4BFFrTLIob5TB0EOH1L/d24FQn4rQUpeOEfBl8FvfKP943HR0IfklrDH+E/gZTnpV5jZWL7tZ n+PmPVtRR70bI47pohGg+aRJL6T4ssG0qo0xJHBE+EIDADTE+6aMyJUZwtWzLtYhk3ckSI58M ZiZaqMfRTC1hbguge8CuqSeYELLMgEF7yudsxoxTBtgnFZoA+kx7DOYnfGrqjJMy9AMR/Z4ln YKC5N54SEChGvOHl53WqCGk5zBoFLFquYI1zZ+gJQTVpRXlAPfy/K1RpYowtqXAze+mgCrXx4 ooi8e+lXkflBC/vg+T2ZUBBVbSSaPMsYeTj/Cjwm0y1lJhTaLhELVH3sRZpx4tinV2Izoa7ab 5oD0L+q6bBcUw68QyUbH8uZrVfn1SRp/vSJaadiwfhW4XQeo0ekTmos1Sfw82cGLDGhMS0lSR w1+0tj7afWPRXAFat2RsuD4wPE25949AXFmkjNeFS4Kq0N+d1d5cA1AADtvcPdoGl0CL0oBtC FLpzkHQfar/vqSn4YEpy/Tq8LQagnDkmONbE/4nnWq5rJn4dsNx8/z0Tp0Ik6BPJmkHYTMhl+ jiCKVaTGcIuGY7XU Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote: > > -struct syscore_ops mvebu_mbus_syscore_ops = { > +static struct syscore_ops mvebu_mbus_syscore_ops = { > .suspend = mvebu_mbus_suspend, > .resume = mvebu_mbus_resume, > }; > Looks good, but I immediately thought it should be "const" as well. Unfortunately there is a list_head in them, so that isn't easy, but if anyone has an idea for how to make these all const, that would be nice. Anyway, that shouldn't stop your patch from getting merged, so Acked-by: Arnd Bergmann (also for patch 1/2). Arnd