From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933798AbcBCVIP (ORCPT ); Wed, 3 Feb 2016 16:08:15 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:49216 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933491AbcBCVIM (ORCPT ); Wed, 3 Feb 2016 16:08:12 -0500 From: Arnd Bergmann To: Felipe Balbi Cc: Bin Liu , Felipe Balbi , balbif@gmail.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Date: Wed, 03 Feb 2016 22:08:02 +0100 Message-ID: <9451477.tmYKHlsitn@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <87wpqlptmt.fsf@ti.com> References: <1749004.q1rSF7t8cz@wuerfel> <20160120180833.GA5433@uda0271908> <87wpqlptmt.fsf@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:CqBwvmArmODRFezZOFQ44nmB1hcCPX6jQQ3n3O8eYUHas6xe5oy Mj1eQX5NUBwzuC6TcvMqLStzK5s9LvuVSCZDMG9RxRDdc8yqrGHWNrzZ9bnMS1qsfx0qn1y m5DM7jtbGXwjdkZAFXVfJvfKzIQZJlZNYnBVGo2bJ0FOEFCNhDnglux5lMqegXvPKUbZPgK sZHj4hJJ/2m7jPD85ALYQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:c7SFpx122g4=:iN7sg8Wn4ND2IKaEOwFxaN wKcwhsDNCl+dqS6W6rWrp7VJxL1BuxAnIVEpQsLzEfqKva7taFYy9Q1giwUEE9fmQGTISZQX1 NqeT4bzrA1d6zu2Amh6U8V+25/hpPewoLmCwV2gMzdME6xRzuyq+ljXnytIXXSHBpbMt8XKBU ZoJESzlb4rgGytIqkW2OYEUVASj+f+tX0Mf3mg+CEOdkSfGV2JLiwalcA6fk1lFyeGY1VYm8R QDUTCgKHYQLvwk0ejWMcY0UfNPusGvVbtbXJXTweLoc722bnRkfs4qeHydSt092SNcChwihxs lMS0cZx5sJYPAXwQymmrFSzmke0whgxscBTQZWyQWaGddmCKIU5CJioIuYUs+lHXfcaA3yhNc Np/2nyEarNjSwGoAooTwwxBUu18aqjzO+brx5x3eIOAgsB7lxmaskpmhOX/qDtFFg6omNNJ1X 3A9tLdyjOQi+rO3AGJTuzLJkBhdDV7XZYmqWuGnfm//2dtvqN2BvlMtaWDOMOegtMSviILmSJ Zd4fcGC51IxYFELc/UTq0lIA14OSNKHZTOl+D5KU1lThqrkj5xDDWiIh1ocSt+4sZTiV8aDKF nMp87duVYDSJYEGoCSR9KHpJSl1iAYaC+3IYGiw6umADd9zazsQeljVveJdOmN1VizwQ1cVtd QB8lVeReh51buabT+ZhUcY0bpyKO6B0/sbopWFrGbeJhTGKwuLHRwUY7pskSYIgskmrV+bjh6 jvD8OJq/Fw4hpw9k Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 03 February 2016 19:54:02 Felipe Balbi wrote: > > hi, > > Bin Liu writes: > > On Wed, Jan 20, 2016 at 11:56:34AM +0100, Arnd Bergmann wrote: > >> The phy-am335x driver accidentally selects 'USB_COMMON', which is > >> not correct as that symbol should indicate whether USB host or > >> target mode is enabled, but it might not: > >> > >> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET)) > > > > Is it possible to have a .config which has either USB nor USB_GADGET > > set but AM335X_PHY_USB is set to be in the situation as in the warning > > above? > > > >> > >> This changes the 'select' into 'depends on', as it should have > >> been initially. > > > > Using 'depends on' causes AM335x_PHY_USB driver unable to built-in, > > since USB_COMMON is an invisible option and its defualt is 'M'. > > > yeah, USB_COMMON is supposed to be selected, not depended upon. That means we should do something like the patch below? Fine with me too, but maybe you can write the changelog for that, as I don't know the background behind the logic. Arnd diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index e7e117d5dbbe..df005f5a0e0c 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -249,7 +249,8 @@ config PHY_SUN9I_USB tristate "Allwinner sun9i SoC USB PHY driver" depends on ARCH_SUNXI && HAS_IOMEM && OF depends on RESET_CONTROLLER - depends on USB_COMMON + depends on USB_SUPPORT + select USB_COMMON select GENERIC_PHY help Enable this to support the transceiver that is part of Allwinner diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index 8ed451dd651e..8689dcba5201 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -31,8 +31,6 @@ if USB_SUPPORT config USB_COMMON tristate - default y - depends on USB || USB_GADGET config USB_ARCH_HAS_HCD def_bool y @@ -41,6 +39,7 @@ config USB_ARCH_HAS_HCD config USB tristate "Support for Host-side USB" depends on USB_ARCH_HAS_HCD + select USB_COMMON select NLS # for UTF-8 strings ---help--- Universal Serial Bus (USB) is a specification for a serial bus diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index af5d922a8f5d..2057add439f0 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -15,6 +15,7 @@ menuconfig USB_GADGET tristate "USB Gadget Support" + select USB_COMMON select NLS help USB is a master/slave protocol, organized with one master