From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Yiyang Wu <toolmanp@tlmp.cc>
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH V4 2/2] erofs: refactor read_inode calling convention
Date: Mon, 2 Sep 2024 17:54:22 +0800 [thread overview]
Message-ID: <94737216-af40-44b0-ab3e-e5bfdbffab5f@linux.alibaba.com> (raw)
In-Reply-To: <20240902093412.509083-1-toolmanp@tlmp.cc>
On 2024/9/2 17:34, Yiyang Wu wrote:
> Refactor out the iop binding behavior out of the erofs_fill_symlink
> and move erofs_buf into the erofs_read_inode, so that erofs_fill_inode
> can only deal with inode operation bindings and can be decoupled from
> metabuf operations. This results in better calling conventions.
>
> Note that after this patch, we do not need erofs_buf and ofs as
> parameters any more when calling erofs_read_inode as
> all the data operations are now included in itself.
>
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Link: https://lore.kernel.org/all/20240425222847.GN2118490@ZenIV/
> Signed-off-by: Yiyang Wu <toolmanp@tlmp.cc>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
next prev parent reply other threads:[~2024-09-02 9:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 8:31 [PATCH V4 0/2] erofs: refactor fast_symlink and read_inode Yiyang Wu
2024-09-02 8:31 ` [PATCH V4 1/2] erofs: use kmemdup_nul in erofs_fill_symlink Yiyang Wu
2024-09-02 8:52 ` Gao Xiang
2024-09-02 9:04 ` Gao Xiang
2024-09-09 3:37 ` Chao Yu
2024-09-02 8:31 ` [PATCH V4 2/2] erofs: refactor read_inode calling convention Yiyang Wu
[not found] ` <ca8dea24-1ef2-46a8-bfca-72aeffa1f6e6@linux.alibaba.com>
2024-09-02 9:34 ` Yiyang Wu
2024-09-02 9:54 ` Gao Xiang [this message]
2024-09-03 2:37 ` Gao Xiang
2024-09-09 3:41 ` Chao Yu
2024-09-02 9:36 ` Yiyang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94737216-af40-44b0-ab3e-e5bfdbffab5f@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=toolmanp@tlmp.cc \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox