Re: [PATCH 2/3] f2fs: fix to add missing iput() in gc_data_segment()

Jaegeuk Kim
2024-05-09T00:46:31Z

On 05/06, Chao Yu wrote:
> During gc_data_segment(), if inode state is abnormal, it missed to call
> iput(), fix it.
>
> Fixes: 132e3209789c ("f2fs: remove false alarm on iget failure during GC")
> Fixes: 9056d6489f5a ("f2fs: fix to do sanity check on inode type during garbage collection")
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/gc.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 8852814dab7f..e86c7f01539a 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1554,10 +1554,15 @@ static int gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum,
> int err;
>
> inode = f2fs_iget(sb, dni.ino);
> - if (IS_ERR(inode) || is_bad_inode(inode) ||
> - special_file(inode->i_mode))
> + if (IS_ERR(inode))
> continue;
>
> + if (is_bad_inode(inode) ||
> + special_file(inode->i_mode)) {
> + iput(inode);

iget_failed() called iput()?

> + continue;
> + }
> +
> err = f2fs_gc_pinned_control(inode, gc_type, segno);
> if (err == -EAGAIN) {
> iput(inode);
> --
> 2.40.1