From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D37BC43334 for ; Tue, 12 Jul 2022 12:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233339AbiGLMyn (ORCPT ); Tue, 12 Jul 2022 08:54:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233321AbiGLMym (ORCPT ); Tue, 12 Jul 2022 08:54:42 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7CC36AA761; Tue, 12 Jul 2022 05:54:41 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A1A1D1596; Tue, 12 Jul 2022 05:54:41 -0700 (PDT) Received: from [10.57.85.194] (unknown [10.57.85.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2D11B3F70D; Tue, 12 Jul 2022 05:54:39 -0700 (PDT) Message-ID: <94ab770b-8a8a-4299-a54e-2ff77afb9e04@arm.com> Date: Tue, 12 Jul 2022 13:54:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/4] dt-binding:perf: Add Amlogic DDR PMU Content-Language: en-GB To: Jiucheng Xu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Will Deacon , Mark Rutland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Chris Healy References: <20220712063641.2790997-1-jiucheng.xu@amlogic.com> <20220712063641.2790997-4-jiucheng.xu@amlogic.com> From: Robin Murphy In-Reply-To: <20220712063641.2790997-4-jiucheng.xu@amlogic.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-07-12 07:36, Jiucheng Xu wrote: > Add binding documentation for the Amlogic G12 series DDR > performance monitor unit. > > Signed-off-by: Jiucheng Xu > --- > .../devicetree/bindings/perf/aml-ddr-pmu.yaml | 51 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/perf/aml-ddr-pmu.yaml > > diff --git a/Documentation/devicetree/bindings/perf/aml-ddr-pmu.yaml b/Documentation/devicetree/bindings/perf/aml-ddr-pmu.yaml > new file mode 100644 > index 000000000000..c586b4ab4009 > --- /dev/null > +++ b/Documentation/devicetree/bindings/perf/aml-ddr-pmu.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/perf/aml-ddr-pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic G12 DDR performance monitor > + > +maintainers: > + - Jiucheng Xu > + > +properties: > + compatible: > + oneOf: > + - enum: > + - aml,g12-ddr-pmu > + - items: > + - enum: > + - aml,g12-ddr-pmu > + - const: aml,g12-ddr-pmu Judging by what the driver actually implements, this should probably be: compatible: items: - enum: - amlogic,g12a-ddr-pmu - amlogic,g12b-ddr-pmu - amlogic,sm1-ddr-pmu - const: amlogic,g12-ddr-pmu There doesn't seem much point in allowing only the common compatible without a SoC-specific identifier. Note also that "aml," is not the documented vendor prefix. > + > + reg: > + maxItems: 2 > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - model Remove this, and use the compatible strings properly as above. > + - dmc_nr > + - chann_nr I suspect those could probably be inferred from the correct compatible string, but if not (i.e. within one SoC you have multiple PMUs supporting the same events but with different numbers of usable channels), then document what exactly they mean. > + - reg > + - interrupts > + - interrupt-names As mentioned in the driver review, if you really want to use a named interrupt (which should usually be unnecessary when there's only one), it has to be a defined name. DT is not a mechanism for overriding what Linux shows in /proc/interrupts. Thanks, Robin. > + > +additionalProperties: false > + > +examples: > + - | > + ddr_pmu: ddr_pmu { > + compatible = "amlogic,g12-ddr-pmu"; > + model = "g12a"; > + dmc_nr = <1>; > + chann_nr = <4>; > + reg = <0x0 0xff638000 0x0 0x100 > + 0x0 0xff638c00 0x0 0x100>; > + interrupts = ; > + interrupt-names = "ddr_pmu"; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index fd2a56a339b4..ac0a1df4622d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1055,6 +1055,7 @@ M: Jiucheng Xu > S: Supported > W: http://www.amlogic.com > F: Documentation/admin-guide/perf/aml-ddr-pmu.rst > +F: Documentation/devicetree/bindings/perf/aml-ddr-pmu.yaml > F: drivers/perf/amlogic/ > F: include/soc/amlogic/ >