From: PJ Waskiewicz <ppwaskie@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Lukas Wunner <lukas@wunner.de>,
linux-cxl@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] cxl/acpi.c: Add buggy BIOS hint for CXL ACPI lookup failure
Date: Mon, 08 Apr 2024 21:22:55 -0700 [thread overview]
Message-ID: <94bce3e14a32d017c0f8acb6726a3484fda01cfd.camel@kernel.org> (raw)
In-Reply-To: <ZhRii1BAg86gccWM@snoopy>
On Mon, 2024-04-08 at 14:32 -0700, PJ Waskiewicz wrote:
> >
> > Turns out that straightforward message is aleady a driver message,
> > but
> > it gets skipped in this case. So, I am thinking of cleanup /
> > clarification along the following lines:
> >
> > 1/ Lean on the existing cxl_get_chbs() validation paths to report
> > on
> > errors
> >
> > 2/ Include the device-name rather than the UID since if UID is
> > unreliable it does not help you communicate with your BIOS vendor.
> > I.e.
> > give a breadcrumb for the BIOS engineer to match the AML device
> > name
> > with the CEDT content.
> >
> > 3/ Do not fail driver load on a single host-bridge parsing failure
> >
> > 4/ These are all cxl_acpi driver init events, so consistently use
> > the
> > ACPI0017 device, and the cxl_acpi driver, as the originator of the
> > error
> > message.
> >
> > Would this clarification have saved you time with the debug?
I guess I should have asked: would you like me to pull this patch in
and give it a test on a known broken host? I'm happy to do it.
-PJ
next prev parent reply other threads:[~2024-04-09 4:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 21:05 [PATCH 1/1] cxl/acpi.c: Add buggy BIOS hint for CXL ACPI lookup failure ppwaskie
2024-04-07 21:28 ` Lukas Wunner
2024-04-08 2:03 ` PJ Waskiewicz
2024-04-08 8:34 ` Jonathan Cameron
2024-04-08 19:29 ` PJ Waskiewicz
2024-04-08 20:45 ` Dan Williams
2024-04-08 21:32 ` PJ Waskiewicz
2024-04-09 4:22 ` PJ Waskiewicz [this message]
2024-04-08 16:54 ` Dan Williams
2024-04-08 19:25 ` PJ Waskiewicz
2024-04-09 13:22 ` Bjorn Helgaas
2024-04-29 5:57 ` PJ Waskiewicz
2024-04-29 15:31 ` Bjorn Helgaas
2024-04-29 18:35 ` Dan Williams
2024-05-01 15:28 ` PJ Waskiewicz
2024-05-01 15:47 ` Dan Williams
2024-05-02 17:34 ` PJ Waskiewicz
2024-05-02 18:29 ` Dan Williams
2024-05-01 17:54 ` Bjorn Helgaas
2024-05-02 17:30 ` PJ Waskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94bce3e14a32d017c0f8acb6726a3484fda01cfd.camel@kernel.org \
--to=ppwaskie@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox