Re: [PATCH 2/2] media: dt-bindings: Use additionalProperties: false for endpoint: properties:

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/10/2024 10:31, Bryan O'Donoghue wrote:
> On 14/10/2024 08:45, Krzysztof Kozlowski wrote:
>> I do not understand the reasoning behind this change at all. I don't
>> think DT maintainers ever suggested it (in fact, rather opposite:
>> suggested using unevaluatedProps) and I think is not a consensus of any
>> talks.
> 
> No there is not but then, how do you give consistent feedback except 
> proposing something to be a baseline.
> 
> On the one hand you have upstream additionalProperties: false and 
> unevaluatedProperites: false - it'd be better to have a consistent 
> message on which is to be used.

Well, I am afraid that push towards additionalProps will lead to grow
common schema (video-interface-devices or video-interfaces) into huge
one-fit-all binding. And that's not good.

If a common binding for a group of devices encourages you to list its
subset, then it is not that common.

Solution is to fix that, e.g. split it per classes of devices.

Or don't care and use unevaluatedProps because it makes people's life
easier and is still correct. If it is not correct, then this should be
used as an argument.

Best regards,
Krzysztof