From: David Howells <dhowells@redhat.com>
To: Julia Lawall <julia@diku.dk>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] arch/frv/kernel/sys_frv.c: add missing fput
Date: Thu, 27 Nov 2008 15:05:52 +0000 [thread overview]
Message-ID: <9512.1227798352@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0811271524340.15160@pc-004.diku.dk>
Julia Lawall <julia@diku.dk> wrote:
> - if (pgoff & ((1<<(PAGE_SHIFT-12))-1))
> - return -EINVAL;
> + if (pgoff & ((1<<(PAGE_SHIFT-12))-1)) {
> + error = -EINVAL;
> + goto out_file;
> + }
There's a better way to fix this. The check on pgoff should be done before
fget() is called.
David
prev parent reply other threads:[~2008-11-27 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 14:25 [PATCH] arch/frv/kernel/sys_frv.c: add missing fput Julia Lawall
2008-11-27 15:05 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9512.1227798352@redhat.com \
--to=dhowells@redhat.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox