From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14ABEC432BE for ; Thu, 29 Jul 2021 05:59:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7D9B61042 for ; Thu, 29 Jul 2021 05:59:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234276AbhG2F7S (ORCPT ); Thu, 29 Jul 2021 01:59:18 -0400 Received: from foss.arm.com ([217.140.110.172]:41064 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233899AbhG2F7R (ORCPT ); Thu, 29 Jul 2021 01:59:17 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5AF186D; Wed, 28 Jul 2021 22:59:14 -0700 (PDT) Received: from [10.163.65.237] (unknown [10.163.65.237]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6E9F53F66F; Wed, 28 Jul 2021 22:59:10 -0700 (PDT) Subject: Re: [PATCH v4 11/12] mm/debug_vm_pgtable: Remove unused code To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, gerald.schaefer@linux.ibm.com, aneesh.kumar@linux.ibm.com, christophe.leroy@csgroup.eu, cai@lca.pw, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com References: <20210727061401.592616-1-gshan@redhat.com> <20210727061401.592616-12-gshan@redhat.com> From: Anshuman Khandual Message-ID: <95432fbb-2b86-e09a-9f9d-02c4db262ebf@arm.com> Date: Thu, 29 Jul 2021 11:29:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210727061401.592616-12-gshan@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/21 11:44 AM, Gavin Shan wrote: > The variables used by old implementation isn't needed as we switched > to "struct pgtable_debug_args". Lets remove them and related code in > debug_vm_pgtable(). > > Signed-off-by: Gavin Shan > --- > mm/debug_vm_pgtable.c | 54 ------------------------------------------- > 1 file changed, 54 deletions(-) > > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index 0611b5f31e89..162ff6329f7b 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -1201,15 +1201,7 @@ static int __init init_args(struct pgtable_debug_args *args) > static int __init debug_vm_pgtable(void) > { > struct pgtable_debug_args args; > - struct vm_area_struct *vma; > - struct mm_struct *mm; > - pgd_t *pgdp; > - p4d_t *p4dp; > - pud_t *pudp; > - pmd_t *pmdp, *saved_pmdp, pmd; > pte_t *ptep; > - pgtable_t saved_ptep; > - unsigned long vaddr; > spinlock_t *ptl = NULL; > int idx, ret; > > @@ -1218,41 +1210,6 @@ static int __init debug_vm_pgtable(void) > if (ret) > return ret; > > - vaddr = get_random_vaddr(); > - mm = mm_alloc(); > - if (!mm) { > - pr_err("mm_struct allocation failed\n"); > - return 1; > - } > - > - vma = vm_area_alloc(mm); > - if (!vma) { > - pr_err("vma allocation failed\n"); > - return 1; > - } > - > - pgdp = pgd_offset(mm, vaddr); > - p4dp = p4d_alloc(mm, pgdp, vaddr); > - pudp = pud_alloc(mm, p4dp, vaddr); > - pmdp = pmd_alloc(mm, pudp, vaddr); > - /* > - * Allocate pgtable_t > - */ > - if (pte_alloc(mm, pmdp)) { > - pr_err("pgtable allocation failed\n"); > - return 1; > - } > - > - /* > - * Save all the page table page addresses as the page table > - * entries will be used for testing with random or garbage > - * values. These saved addresses will be used for freeing > - * page table pages. > - */ > - pmd = READ_ONCE(*pmdp); > - saved_pmdp = pmd_offset(pudp, 0UL); > - saved_ptep = pmd_pgtable(pmd); > - > /* > * Iterate over the protection_map[] to make sure that all > * the basic page table transformation validations just hold > @@ -1335,17 +1292,6 @@ static int __init debug_vm_pgtable(void) > pgd_populate_tests(&args); > spin_unlock(&(args.mm->page_table_lock)); > > - p4d_free(mm, p4d_offset(pgdp, 0UL)); > - pud_free(mm, pud_offset(p4dp, 0UL)); Small nit. saved_p4dp and saved_pudp could have been dropped in this patch rather than the previous one. Previous build error with W=1 might not have been a problem as there was a remaining usage after the assignment. > - pmd_free(mm, saved_pmdp); > - pte_free(mm, saved_ptep); > - > - vm_area_free(vma); > - mm_dec_nr_puds(mm); > - mm_dec_nr_pmds(mm); > - mm_dec_nr_ptes(mm); > - mmdrop(mm); > - > destroy_args(&args); > return 0; > } > With or without the above change. Reviewed-by: Anshuman Khandual