From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753916AbcEBPVT (ORCPT ); Mon, 2 May 2016 11:21:19 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:49925 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbcEBPVK (ORCPT ); Mon, 2 May 2016 11:21:10 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org, Christoph Hellwig Cc: Yury Norov , Andre Przywara , linux-kernel@vger.kernel.org Subject: Re: [question] pread2, pwrite2 unistd symbols for compat Date: Mon, 02 May 2016 17:20:22 +0200 Message-ID: <9552994.HgmuyIW9Ty@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160502134706.GA11396@yury-N73SV> References: <20160502134706.GA11396@yury-N73SV> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:jW9fIOB5u7AhdQGrr+YFAtylDAnZR9Gz0tUJk0oujnHexvzuspF q8a17R003renoa1A6U3sArJMCy4l5c5GQvFf6GTLLf7vLK+93FiNze6ntEajrwe9QQrh13S OBN5Sq90LganfAePjGO88BLPErfzCu/1/E48EvrTPAchVm3yLCR1xPHpevweD3amCRAgUNt pT7Q6+enFfg6LKQDMcVVw== X-UI-Out-Filterresults: notjunk:1;V01:K0:IYcGEwJGIAs=:yQGXLkk7ROvpLwE0fy90v0 zXhL5L8f0SFb70B149yfSRw2OZDXVjLzYkFsRMaOPgBTLsgMgJFLE+cntwe/d0GW845kBS/Ve 9Pd58Tw5N1up3TsqGqnr1RuH4ospHOHaBuHIhGaEn/yrLd1Nsl1et1x6dyqnLTD8Q8+KD4qtX OcA0MxncvJ9R0jtNmD4Um62URGhBbAwhp9F0yh8a76NqMqW/tyesVOB/0ZxBs6HD2mp0oEEFD eqWLtHy6tvyH8UKzUg5WZZYJv8uValD83nkbPa9dZjraJqrP2e2bcu+GvAIYoaO/waXe5Yg+T LGfuknFU+04IpQjlSrv2hPpJKrqbmwufBg62ysIzcFuSYcM55h8gigx2vM0LP/PHg345X+oP7 B/pNICBCC8OHfybmS8YAiI8VTUKdkcvNGeqxW4Y1aObRTPs6S6+pLfNMb1aILY5SK21B4O/e4 aXVDs0Z10RHNSmSMYbWIQsgjmaTsJLRL35ZtVenxnU13a6cjxPfqAZEIEYHPoEMLzS90lkuZ6 3L7pwi9EqGEj7xZmbaqR6RlpZU3LulW/o5rU56XjAVnTXSVgvx6CoHxx+Hdpuh+b3ZDQ6Pbei OHrKWkestDencl6tIQWK6t4v04gFST0nmVR8VGPmWI0bZmqTGrnpsm/KS5grruFGA+PIRjdmM L0YEuC/0uwtFpZSKAD0LTvkW42kZRgGLDcqlAlb2IsNrMYRYAlowQbtBLTwbBOxl7VCpBqhrM AGh8YFrnVlVkvXuk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 02 May 2016 16:47:06 Yury Norov wrote: > Hi Andre, > > In patch 987aedb5d (eneric syscalls: wire up preadv2 and pwritev2 > syscalls) you add those syscalls with __SYSCALL macro. However, > compat architectures that does not use generic unistd (mips, s390), > declare compat version in their syscall tables. Maybe we'd replace > __SYSCALL macro with __SC_COMP? I think you are right and your change looks good. After I got the original patch from Andre and the same one from Christoph, I did not consider the possibility that they were both wrong and so I applied Andre's version. Can you resend the patch in proper form (with a Signed-off-by line, rebased to mainline and with a changelog I can use)? I'll apply it as soon as I get an Ack from Christoph then. Thanks! Arnd > diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h > index 723479c..6ed4613 100644 > --- a/include/uapi/asm-generic/unistd.h > +++ b/include/uapi/asm-generic/unistd.h > @@ -721,9 +721,9 @@ __SC_WRAP(__NR_mlock2, sys_mlock2) > #define __NR_copy_file_range 285 > __SC_WRAP(__NR_copy_file_range, sys_copy_file_range) > #define __NR_preadv2 286 > -__SYSCALL(__NR_preadv2, sys_preadv2) > +__SC_COMP(__NR_preadv2, sys_preadv2, compat_sys_preadv2) > #define __NR_pwritev2 287 > -__SYSCALL(__NR_pwritev2, sys_pwritev2) > +__SC_COMP(__NR_pwritev2, sys_pwritev2, compat_sys_pwritev2) > > #undef __NR_syscalls > #define __NR_syscalls 288 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel