public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: fix sparse warnings
Date: Thu, 05 Feb 2015 17:02:46 +0200	[thread overview]
Message-ID: <9554101.sx7IWG6fvB@avalon> (raw)
In-Reply-To: <1423141338-18511-1-git-send-email-prabhakar.csengg@gmail.com>

Hi Prabhakar,

Thank you for the patch.

On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> 
> this patch fixes following sparse warnings:
> 
> uvc_video.c:283:5: warning: symbol 'uvcg_video_pump' was not declared.
> Should it be static? uvc_video.c:342:5: warning: symbol 'uvcg_video_enable'
> was not declared. Should it be static? uvc_video.c:381:5: warning: symbol
> 'uvcg_video_init' was not declared. Should it be static?
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Felipe, could you please take this in your tree ?

> ---
>  drivers/usb/gadget/function/uvc_video.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/function/uvc_video.c
> b/drivers/usb/gadget/function/uvc_video.c index 9cb86bc..50a5e63 100644
> --- a/drivers/usb/gadget/function/uvc_video.c
> +++ b/drivers/usb/gadget/function/uvc_video.c
> @@ -21,6 +21,7 @@
> 
>  #include "uvc.h"
>  #include "uvc_queue.h"
> +#include "uvc_video.h"
> 
>  /*
> --------------------------------------------------------------------------
> * Video codecs

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2015-02-05 15:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 13:02 [PATCH] usb: gadget: fix sparse warnings Lad Prabhakar
2015-02-05 15:02 ` Laurent Pinchart [this message]
2015-02-05 18:08   ` Felipe Balbi
2015-02-08 15:46     ` Laurent Pinchart
2015-02-23 15:22       ` Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2015-02-05 13:11 Lad Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9554101.sx7IWG6fvB@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox