From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC911233722 for ; Sun, 12 Apr 2026 16:06:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776009967; cv=none; b=hDz98tmt+1On17Z+jtMqN6thtzBdyqtODyKeXkX4twqIHUzfGCU9F4IOED5g5xg7OYaWsJzZqZ+xe/XGTwkr89xpw7UXzuTNkQ9erpuN9rgZrUkRBHoJXOvbJ3+ZE11zonI/nRCCcJjxOFjmYf9F2PC7xQhBjHUygrN7xeeCu14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776009967; c=relaxed/simple; bh=NDKr9QdUyNc666EXNPZZTTRT8Fp3Utw5Fsw1pz5zNCY=; h=From:Date:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=Fnks9F3E7am4F76A8lZuVCUtI3e+pF3mOMRlVFSacGwt/bP2jBB9lWD3kPCkuIOSY5b501hd0BjGF9RtlFLC/MmuTyXlLajqLJFuRScBcAypHEcr7b1vFtvmWipTelAU1Z6hRU1JGWTqiKCe0d7r6ivp0dchzPghooif0iK2gXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=azfizHXE; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="azfizHXE" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488c21c636dso20890795e9.2 for ; Sun, 12 Apr 2026 09:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776009964; x=1776614764; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to; bh=YNqyYozPV+H8H8mQnpyUjNzrBoRXycgD4jouK+hqsBk=; b=azfizHXEnkWxYWvtAeFGLUJpqjU5tE8nq2AZ3qXlMCAUSI+kYCTj1yE36E4c816bMr mZpdYSV901Jc2ukx4lg+4ajpr0CaqbqSH5QabjyR8iQhZ1MnsqtQDrxaLmGrLIKyOG6f GSX43xoM0sUVIS8r1N0ciS99Y6rUp02dRv6Fr3rmo+J5boQHUSwYEQR3tKFGiKX7r/S+ EAfNsFjDQsLUx2Ivh/pvhZ2QJT8O18aa+8eFFUs7Bke9KPWqh2EjgGu5ptpUoOhsjhvk sEXMjS0JAuqYITs4yB9zjTMVSOK8d8BKBN00+JCdKmDgcZA3nT4yfDWQA5NNbxOU94jz WsRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776009964; x=1776614764; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YNqyYozPV+H8H8mQnpyUjNzrBoRXycgD4jouK+hqsBk=; b=kBYWt9jrlF4FJ/A6wUiciyF4zKgn7LLPVm1hVviSZfsESdJJ/gmRmCQeUFAvcYdgWB fKgU78fObJxDxJaUrNF2kubY5aMari3XRnqTpxv1rUN4Ska88bxe/DIVkDMeSaRjWOic A1ANWoWzGQJYGBtve+Hos/s5SL2oXfdwIRsWMTFyqcH560opRfcUZfINbdarEknbi/Zb 2ds1zvCbyIx3+eTSm9W1ZWxvrN0r3juh4bknnLv7mdt7yjsmxIVZZFoeQqAn+kw9I0n/ 6PKGwFkXbhsScoLi8X1Ht1ye0JEiEg19vzxuQKDHts78pm2+kAlY0xpw+RkQ1Bb7lSbj /Fiw== X-Forwarded-Encrypted: i=1; AJvYcCU7Et/j4LDXmZDZmeYg5Yw5Bq5d21j1UPaPjYc0+MraN8Io3tr8IQ89auZzQ0+HRCr+aSSEcpvsOciIf+k=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9drB5XIvG7VYIpO4H/8FsxcgjPOnRxLeqE4cSR4rlQXjhZb+k BFIOajchi8OyFfA5oKn8y7FLIG46vbrI3o8UAtYVYP4k1brCCqBXRFo= X-Gm-Gg: AeBDieuwyj1IcFTUE51O3rysXPp7bJWn1VJbJeXsdWqYzWi/Fw5VZkmZG/awge/hGcZ ByO6POoCQ2bJkWjZ4Wo3Nqp5URKWJxRQbUxEkShfUgWejibtjEBnGlEEdloUnTRf3ZczgbCx40M 9poW59RCJ2GOlvn7Is0LuoIlXnhZvo9qxAutnWOXpQd2xAxHvI2Vq32+aKXUDDHSybZYIWT+9SK sLAzVSV1IiZiBlPrOneg4k8N6IC4XIG3tLXlT//k4A0DBWuDguH2cfFGIZjTwYorJVwBWITxIB1 SQ8SOeJ80S0VYSoRlvT2qyiQkh2FVJUhfvMiHyP2peoE3lOLX/IZc3efJ6mjY/htRFAXTLiLyyO NaHEvsNYNE74jBZ/pxcbPpv95yNFpnemgbTVJj4bdXebTLIuaHzvqlHNH9qnlAjMjlC8Sd9eJyo L6ymLemVfgaFgYFAZS0T6zrZdvQeGUiyEOW/5St+NASDAwz8JrCQO8k5P738N8XIa2wpROFRvFe cUOI2skt0J08NoeSeGk7Mo= X-Received: by 2002:a05:600c:474c:b0:485:35d3:ce59 with SMTP id 5b1f17b1804b1-488d68101edmr127318045e9.10.1776009963842; Sun, 12 Apr 2026 09:06:03 -0700 (PDT) Received: from ehlo.thunderbird.net ([31.223.145.20]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e5c981sm26507849f8f.33.2026.04.12.09.06.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Apr 2026 09:06:03 -0700 (PDT) From: Luka Gejak X-Google-Original-From: Luka Gejak Date: Sun, 12 Apr 2026 18:06:00 +0200 To: Josh Hesketh , Greg Kroah-Hartman CC: Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, luka.gejak@linux.dev Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_3/3=5D_staging=3A_rtl8723bs=3A_remove_?= =?US-ASCII?Q?unnecessary_else_after_return_in_sdio=5Fhalinit=2Ec?= User-Agent: Thunderbird for Android In-Reply-To: <20260412150633.12071-3-josh.hesketh@gmail.com> References: <20260412150633.12071-1-josh.hesketh@gmail.com> <20260412150633.12071-3-josh.hesketh@gmail.com> Message-ID: <95E8D91D-326D-4972-90BF-098F3EB556DE@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable LGTM=2E Reviewed-by: Luka Gejak On April 12, 2026 5:06:33 PM GMT+02:00, Josh Hesketh wrote: >Remove else branch following a conditional return statement > >Signed-off-by: Josh Hesketh >--- >v2: > - Rebased on staging-next > - Split from original patch 1/2 > drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec b/drivers/sta= ging/rtl8723bs/hal/sdio_halinit=2Ec >index 4a4f6b03253a=2E=2Eed82860ae9b6 100644 >--- a/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec >+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit=2Ec >@@ -641,11 +641,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) > padapter->bFWReady =3D false; > pHalData->fw_ractrl =3D false; > return ret; >- } else { >- padapter->bFWReady =3D true; >- pHalData->fw_ractrl =3D true; > } >=20 >+ padapter->bFWReady =3D true; >+ pHalData->fw_ractrl =3D true; >+ > rtl8723b_InitializeFirmwareVars(padapter); >=20 > if (pwrctrlpriv->reg_rfoff)