From: "Maxime Ripard" <mripard@kernel.org>
To: "Douglas Anderson" <dianders@chromium.org>
Cc: airlied@gmail.com, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
liviu.dudau@arm.com, orsonzhai@gmail.com, rfoss@kernel.org,
robh@kernel.org, sam@ravnborg.org, steven.price@arm.com,
tzimmermann@suse.de, zhang.lyra@gmail.com,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Maxime Ripard" <mripard@kernel.org>
Subject: Re: [RFT PATCH 10/15] drm/sprd: Call drm_atomic_helper_shutdown() at remove time
Date: Mon, 04 Sep 2023 07:54:34 +0000 [thread overview]
Message-ID: <95a50c7653a014d447072039f12144d5.mripard@kernel.org> (raw)
In-Reply-To: <20230901164111.RFT.10.I7a2dd349cb52bae53280d0a49e22cc27b923274b@changeid>
On Fri, 1 Sep 2023 16:41:21 -0700, Douglas Anderson wrote:
> Based on grepping through the source code, this driver appears to be
> missing a call to drm_atomic_helper_shutdown() at remove time. Let's
> add it.
>
> The fact that we should call drm_atomic_helper_shutdown() in the case
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
next prev parent reply other threads:[~2023-09-04 7:54 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 23:41 [RFT PATCH 00/15] drm: non-drm-misc drivers call drm_atomic_helper_shutdown() at the right times Douglas Anderson
2023-09-01 23:41 ` [RFT PATCH 01/15] drm/armada: Call drm_atomic_helper_shutdown() at shutdown time Douglas Anderson
2023-09-03 15:53 ` Russell King (Oracle)
2023-09-04 7:36 ` Maxime Ripard
2023-09-04 7:55 ` Russell King (Oracle)
2023-09-04 15:18 ` Maxime Ripard
2023-09-05 14:23 ` Doug Anderson
2023-09-13 15:34 ` Doug Anderson
2023-09-20 18:03 ` Doug Anderson
2023-09-20 18:58 ` Russell King (Oracle)
2023-09-21 18:46 ` Doug Anderson
2023-09-04 7:53 ` Maxime Ripard
2023-09-04 7:56 ` Russell King (Oracle)
2023-09-01 23:41 ` [RFT PATCH 02/15] drm/imx/dcss: " Douglas Anderson
2023-09-04 7:36 ` Maxime Ripard
2023-09-01 23:41 ` [RFT PATCH 03/15] drm/ingenic: " Douglas Anderson
2023-09-04 7:36 ` Maxime Ripard
2023-09-04 9:15 ` Paul Cercueil
2023-09-05 20:16 ` Doug Anderson
2023-09-06 8:39 ` Maxime Ripard
2023-09-13 16:23 ` Doug Anderson
2023-09-14 8:14 ` Maxime Ripard
2023-09-14 22:29 ` Doug Anderson
2023-09-19 9:33 ` Maxime Ripard
2023-09-13 16:25 ` Doug Anderson
2023-09-13 18:00 ` Paul Cercueil
2023-09-13 18:21 ` Doug Anderson
2023-09-01 23:41 ` [RFT PATCH 04/15] drm/kmb: " Douglas Anderson
2023-09-04 7:26 ` Maxime Ripard
2023-09-01 23:41 ` [RFT PATCH 05/15] drm/mediatek: " Douglas Anderson
2023-09-04 7:27 ` Maxime Ripard
2023-09-08 11:51 ` Fei Shao
2023-09-11 16:10 ` Doug Anderson
2023-09-12 6:28 ` Fei Shao
2023-09-01 23:41 ` [RFT PATCH 06/15] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv " Douglas Anderson
2023-09-04 7:27 ` Maxime Ripard
2023-09-01 23:41 ` [RFT PATCH 07/15] drm/tegra: Call drm_atomic_helper_shutdown() " Douglas Anderson
2023-09-04 7:28 ` Maxime Ripard
2023-09-01 23:41 ` [RFT PATCH 08/15] drm/arcpgu: " Douglas Anderson
2023-09-04 7:28 ` Maxime Ripard
2023-09-01 23:41 ` [RFT PATCH 09/15] drm/amdgpu: " Douglas Anderson
2023-09-01 23:41 ` [RFT PATCH 10/15] drm/sprd: Call drm_atomic_helper_shutdown() at remove time Douglas Anderson
2023-09-04 7:54 ` Maxime Ripard [this message]
2023-09-01 23:41 ` [RFT PATCH 11/15] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time Douglas Anderson
2023-09-04 7:54 ` Maxime Ripard
2023-09-01 23:41 ` [RFT PATCH 12/15] drm/gma500: Call drm_helper_force_disable_all() at shutdown/remove time Douglas Anderson
2023-09-04 7:29 ` Maxime Ripard
2023-09-01 23:41 ` [RFT PATCH 13/15] drm/imx/ipuv3: Call drm_atomic_helper_shutdown() at shutdown/unbind time Douglas Anderson
2023-09-04 7:55 ` Maxime Ripard
2023-09-04 8:30 ` Philipp Zabel
2023-09-05 20:29 ` Doug Anderson
2023-09-06 5:47 ` Philipp Zabel
2023-09-06 14:30 ` Doug Anderson
2023-09-13 18:21 ` Doug Anderson
2023-09-01 23:41 ` [RFT PATCH 14/15] drm/radeon: Call drm_helper_force_disable_all() at shutdown/remove time Douglas Anderson
2023-09-04 7:30 ` Maxime Ripard
2023-09-01 23:41 ` [RFT PATCH 15/15] drm/renesas/shmobile: " Douglas Anderson
2023-09-04 7:27 ` Geert Uytterhoeven
2023-09-05 21:10 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95a50c7653a014d447072039f12144d5.mripard@kernel.org \
--to=mripard@kernel.org \
--cc=airlied@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=orsonzhai@gmail.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox