From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 928FB37702E for ; Fri, 17 Apr 2026 07:33:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776411227; cv=none; b=GnKkTGdjvE4xrdR0IBxES5EFQEQt0b8/khDzhtgDTm1Fvp7XHdpuNtCulbX/g2c9bb1FwAdPc6oiXUTZ3Kaf961Ucvt+DYPtxLppZH99oPhztRB0T4AD6r8t7LttJPVXVoLJYDr5kgexRcNisfi/6uipG1+YD5/1XUOIOfVLr6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776411227; c=relaxed/simple; bh=oeOG+ZszsRTbVirZ6pWNVku8hciqTAMTRMfyh9Yt8HY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QHuke/0SD+nN8jC1GQqiRWqUxxK6y4kL27OW6sC+5Px3DrZCWUwuxKOrmvrZD0h8IKToBIqHt3GP6TLbgOKCJ9fqZRatpgKxyYHUNGwXpcOoRFEmqH7fNk/8kelZxYon5LTR/NK5DgnqPZli9E+S1azFDSksXBSWP8gufsGc84g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iBMJrc2G; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iBMJrc2G" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5a3fcb2c718so283196e87.0 for ; Fri, 17 Apr 2026 00:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776411222; x=1777016022; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HgHTSvY/2XubmQ08/1S3AfuwPBtJv9x2QvMC8191EmY=; b=iBMJrc2G4CorKfkdxW8ZQhyL2VHjHz9PKIqnV3xcYZSk1TbvNiyHLIMsBCy8dLYib4 4UOgkYmz2JwCTkBC4Dx8VrUcGuN7d7+8ER3bxAkN0s9YxSIBryjDCzgloz2zNJKIsc/3 sPVvFZFZ0x+mcqHZeik9IHB7YuUQTOP/M6LHrsXBn83iOI1HFmno0maXsYYXmVzpec+W 7zNM0zzRn4KBoeQ76fkZ7pvSS1tmXSqxAmEnwfnq7KGHdKjLjJFY7KxN/qAgtw9MxcxU a+DW409WBxrXH8ty43rltgv+Ka4YMFhBx7Xhs3c5aYIWgAcQaPp4UxTYCCrH7ml+203S NL8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776411222; x=1777016022; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HgHTSvY/2XubmQ08/1S3AfuwPBtJv9x2QvMC8191EmY=; b=oNlVyWeN/fbI607cOa7ImXeK9gtkFLvCb3J6gQ6C36ZR8f8SRNjj9lYW8zTIS9gAab w8E7iIujoitMQp/pJxG6VqG51nhbcaDhAHEuwc30fyhMoKId4iloyKQ0rtmviBzEnXQb rY3UhrJ9rgrwe4rte5FV11dlkvxQoo02hRt4bzBeKTm4AQSOAkxyC0vcxw/czGHtOd6W ihXNrK+sha8rvfjzBIQQpCoarR/zvvRmS4r395GJEd2TEZ0osxgHjmqF1n1frfcR0PJk xX2C7oE4xbL0MbGa/6R7ievL+p/5f1062iz5e6MXqnwejeV2hF8sKL2PV7pufyc31K3x z/6A== X-Forwarded-Encrypted: i=1; AFNElJ/ilQ5BfQivMsQRCiSwWDcCTd+rA5fDD/Wg++Sa3tLhjcG0XXORMCJS7kzSgpAANxmkBFyNOPSEjjD5M4g=@vger.kernel.org X-Gm-Message-State: AOJu0YzvQwBzXz4jH8OCPrkhg1rhoAN5v2QoUgfuCJa+fbXPfh0/khEs f1y37pPCRYSV1OWkhzGew+udknb2zUmLnzz1m51xN1MV5kzqzDwzgHuOKkzTvJCd X-Gm-Gg: AeBDievwPi7qeEL6ab9BQvA8N/oY1hwGZ+EXm8Q/oaB424lbWziCmr8qCHLl8zJOZmA h9ciwGVIjWlLDkgyiS6Me2axtv3V5svBHUUktucnFY/RKmMu02kKJ2XZMWJjCQhhfs9VGKNBqHk z8AxWPB6baCtYk3nyt76tO5r+LwjQqFrSMTJYZvWjE8VYgfm85RJHxjIIq7/teqTmUOzk+SBN7v SsC3SxX4QlydgsxtvNdbaCufsoOs1qzLXg40AzuqslhhCUCjyWdcVP5InripINCQumaH/nmo6ix 8wogkFwak+0g96tzPGg5MERNqSRpO6EYj0A6YeRtYvEVkIdz+ytLCg8xGNFU+vIgXWGEr0cWrvE FYbNUrzkF4JgU5X8T/dP2rQTIBwjasFOv//uoWKlBnLFXDA3+dSSYh/yEpKlJmCS2Z3zSXPVajP bGdO9ODUNqSbEp/9jlSgmSYCkO+6fwt5+G5e+C2rWWHi68CvXC8FcHUPbGYy/PD4xmv98PJg8tM A7ElFjyAP+EgH8JJlGFUjH62E6Ghg== X-Received: by 2002:a05:6512:39c7:b0:5a2:a703:969 with SMTP id 2adb3069b0e04-5a4172f61e8mr477511e87.40.1776411222198; Fri, 17 Apr 2026 00:33:42 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a4185bc58fsm178944e87.30.2026.04.17.00.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 00:33:41 -0700 (PDT) Message-ID: <95c60933-8a78-4908-bc51-d4bd5a3f10de@gmail.com> Date: Fri, 17 Apr 2026 10:33:40 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] power: supply: bd71828: add input current limit property To: Andreas Kemnade Cc: Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260401-bd-inp-limit-v1-1-689eb22531e2@kemnade.info> <20260415221358.59574987@kemnade.info> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260415221358.59574987@kemnade.info> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/04/2026 23:13, Andreas Kemnade wrote: > On Tue, 7 Apr 2026 09:33:25 +0300 > Matti Vaittinen wrote: > >> I am afraid I don't know your use-case for the control of the DCIN input >> limit well enough to decide, if the BD72720 would need something similar >> - or if the VBUS_INLIM should be tied to the same knob. If you have the >> enthusiasm to write some more words ... I am keen on learning! :) > > Justification for this patch is mostly: there is a standard interface > for this functionality and the chip has that functionality. I wasn't doubting the justification for this patch. I was more like wondering if the use-case of the functionality, toggled by the interface, is such that BD72720 VBUS_INLIM should be tied to this same knob. > The bigger picture: Attach a power source with changing properties causes > mess. To repreduce issues at my desk, I have played around with a labor power > supply with changeable current limitation, turining it down to zero (so > power is off) then turning it on slowly again, no charging will happen. My > usual way around such a problem is to clear DCIN_ILIM_EN (will add a sysfs > attribute for that) and set some conservative current. Right. I suppose deciding if the BD72720 should support changing the VBUS_INLIM would require me to have the hardware to do some testing so I could see how it behaves with variable charging currents. I don't currently have that, and I haven't heard of any complaints. Furthermore, AFAIR, there are some differences between the logic of BD71828 and BD72720 (battery assisted mode in BD72720) - so they're not 100% same. Hence, I won't touch the BD72720 for now. Thanks for sharing the details! Yours, -- Matti -- --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~