From: Konrad Dybcio <konradybcio@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>, Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH] PCI: take the rescan lock when adding devices during host probe
Date: Mon, 30 Sep 2024 18:09:48 +0200 [thread overview]
Message-ID: <95e25468-722b-4c6a-b8ea-b142d4a66f72@kernel.org> (raw)
In-Reply-To: <20240926130924.36409-1-brgl@bgdev.pl>
On 26.09.2024 3:09 PM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Since adding the PCI power control code, we may end up with a race
> between the pwrctl platform device rescanning the bus and the host
> controller probe function. The latter needs to take the rescan lock when
> adding devices or may crash.
>
> Reported-by: Konrad Dybcio <konradybcio@kernel.org>
> Fixes: 4565d2652a37 ("PCI/pwrctl: Add PCI power control core code")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
Tested-by: Konrad Dybcio <konradybcio@kernel.org>
Konrad
next prev parent reply other threads:[~2024-09-30 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 13:09 [PATCH] PCI: take the rescan lock when adding devices during host probe Bartosz Golaszewski
2024-09-30 16:09 ` Konrad Dybcio [this message]
2024-10-01 21:11 ` Bjorn Helgaas
2024-10-02 8:36 ` Bartosz Golaszewski
2024-10-02 20:31 ` Konrad Dybcio
2024-10-02 20:53 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95e25468-722b-4c6a-b8ea-b142d4a66f72@kernel.org \
--to=konradybcio@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox