From: "Ding, Shenghao" <shenghao-ding@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: "andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"13916275206@139.com" <13916275206@139.com>,
"zhourui@huaqin.com" <zhourui@huaqin.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Salazar, Ivan" <i-salazar@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chadha, Jasjot Singh" <j-chadha@ti.com>,
"liam.r.girdwood@intel.com" <liam.r.girdwood@intel.com>,
"Yue, Jaden" <jaden-yue@ti.com>,
"yung-chuan.liao@linux.intel.com"
<yung-chuan.liao@linux.intel.com>, "Rao, Dipa" <dipa@ti.com>,
"yuhsuan@google.com" <yuhsuan@google.com>,
"Lo, Henry" <henry.lo@ti.com>, "tiwai@suse.de" <tiwai@suse.de>,
"Xu, Baojun" <baojun.xu@ti.com>, "soyer@irl.hu" <soyer@irl.hu>,
"Baojun.Xu@fpt.com" <Baojun.Xu@fpt.com>,
"judyhsiao@google.com" <judyhsiao@google.com>,
"Navada Kanyana, Mukund" <navada@ti.com>,
"cujomalainey@google.com" <cujomalainey@google.com>,
"Kutty, Aanya" <aanya@ti.com>,
"Mahmud, Nayeem" <nayeem.mahmud@ti.com>,
"savyasanchi.shukla@netradyne.com"
<savyasanchi.shukla@netradyne.com>,
"flaviopr@microsoft.com" <flaviopr@microsoft.com>,
"Ji, Jesse" <jesse-ji@ti.com>,
"darren.ye@mediatek.com" <darren.ye@mediatek.com>,
"antheas.dk@gmail.com" <antheas.dk@gmail.com>
Subject: RE: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Move tas2563_dvc_table into a separate Header file
Date: Tue, 30 Jul 2024 14:14:18 +0000 [thread overview]
Message-ID: <962c985c3d894e3e8f0594022b6ae383@ti.com> (raw)
In-Reply-To: <e8ce11fd-ff6a-4ca0-ac33-5abf20cf242d@sirena.org.uk>
Hi Broonie
> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Tuesday, July 30, 2024 8:27 PM
> To: Ding, Shenghao <shenghao-ding@ti.com>
> Cc: andriy.shevchenko@linux.intel.com; lgirdwood@gmail.com;
> perex@perex.cz; pierre-louis.bossart@linux.intel.com;
> 13916275206@139.com; zhourui@huaqin.com; alsa-devel@alsa-project.org;
> Salazar, Ivan <i-salazar@ti.com>; linux-kernel@vger.kernel.org; Chadha, Jasjot
> Singh <j-chadha@ti.com>; liam.r.girdwood@intel.com; Yue, Jaden <jaden-
> yue@ti.com>; yung-chuan.liao@linux.intel.com; Rao, Dipa <dipa@ti.com>;
> yuhsuan@google.com; Lo, Henry <henry.lo@ti.com>; tiwai@suse.de; Xu,
> Baojun <baojun.xu@ti.com>; soyer@irl.hu; Baojun.Xu@fpt.com;
> judyhsiao@google.com; Navada Kanyana, Mukund <navada@ti.com>;
> cujomalainey@google.com; Kutty, Aanya <aanya@ti.com>; Mahmud, Nayeem
> <nayeem.mahmud@ti.com>; savyasanchi.shukla@netradyne.com;
> flaviopr@microsoft.com; Ji, Jesse <jesse-ji@ti.com>; darren.ye@mediatek.com;
> antheas.dk@gmail.com
> Subject: Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Move
> tas2563_dvc_table into a separate Header file
>
> On Tue, Jul 30, 2024 at 01:24:34AM +0000, Ding, Shenghao wrote:
>
> > One more thing, these day my colleague and I want have some adjustment
> > on the
> > tas2781 driver code to support both i2c and spi interface, and plan to
> > abstract the common part, especially the dsp binary parsing, as a
> > shared lib. Would you be so kind and give us some advice on it? Thanks.
>
> That seems like a sensible and reasonable design - factoring out common code
> is a good idea, there's a number of existing drivers doing things ike that.
> Possibly the biggest example is the Cirrus/Wolfson Arizona drivers and the
> wm_adsp DSPs they use. Do you have specific questions around this?
Thanks for your advice. So far, I have no specific questions. First, I will study
Cirrus/Wolfson Arizona drivers and then find a suitable solution for tas2563/tas2781.
prev parent reply other threads:[~2024-07-30 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 6:11 [PATCH v1] ASoc: tas2781: Move tas2563_dvc_table into a separate Header file Shenghao Ding
2024-07-29 16:42 ` Mark Brown
2024-07-30 1:24 ` [EXTERNAL] " Ding, Shenghao
2024-07-30 12:27 ` Mark Brown
2024-07-30 14:14 ` Ding, Shenghao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=962c985c3d894e3e8f0594022b6ae383@ti.com \
--to=shenghao-ding@ti.com \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=aanya@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=antheas.dk@gmail.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=cujomalainey@google.com \
--cc=darren.ye@mediatek.com \
--cc=dipa@ti.com \
--cc=flaviopr@microsoft.com \
--cc=henry.lo@ti.com \
--cc=i-salazar@ti.com \
--cc=j-chadha@ti.com \
--cc=jaden-yue@ti.com \
--cc=jesse-ji@ti.com \
--cc=judyhsiao@google.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=nayeem.mahmud@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=savyasanchi.shukla@netradyne.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
--cc=yuhsuan@google.com \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zhourui@huaqin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox