RE: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Move tas2563_dvc_table into a separate Header file

Ding, Shenghao
2024-07-30T14:16:17Z

Hi Broonie

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Tuesday, July 30, 2024 8:27 PM
> To: Ding, Shenghao <shenghao-ding@ti.com>
> Cc: andriy.shevchenko@linux.intel.com; lgirdwood@gmail.com;
> perex@perex.cz; pierre-louis.bossart@linux.intel.com;
> 13916275206@139.com; zhourui@huaqin.com; alsa-devel@alsa-project.org;
> Salazar, Ivan <i-salazar@ti.com>; linux-kernel@vger.kernel.org; Chadha, Jasjot
> Singh <j-chadha@ti.com>; liam.r.girdwood@intel.com; Yue, Jaden <jaden-
> yue@ti.com>; yung-chuan.liao@linux.intel.com; Rao, Dipa <dipa@ti.com>;
> yuhsuan@google.com; Lo, Henry <henry.lo@ti.com>; tiwai@suse.de; Xu,
> Baojun <baojun.xu@ti.com>; soyer@irl.hu; Baojun.Xu@fpt.com;
> judyhsiao@google.com; Navada Kanyana, Mukund <navada@ti.com>;
> cujomalainey@google.com; Kutty, Aanya <aanya@ti.com>; Mahmud, Nayeem
> <nayeem.mahmud@ti.com>; savyasanchi.shukla@netradyne.com;
> flaviopr@microsoft.com; Ji, Jesse <jesse-ji@ti.com>; darren.ye@mediatek.com;
> antheas.dk@gmail.com
> Subject: Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Move
> tas2563_dvc_table into a separate Header file
>
> On Tue, Jul 30, 2024 at 01:24:34AM +0000, Ding, Shenghao wrote:
>
> > One more thing, these day my colleague and I want have some adjustment
> > on the
> > tas2781 driver code to support both i2c and spi interface, and plan to
> > abstract the common part, especially the dsp binary parsing, as a
> > shared lib. Would you be so kind and give us some advice on it? Thanks.
>
> That seems like a sensible and reasonable design - factoring out common code
> is a good idea, there's a number of existing drivers doing things ike that.
> Possibly the biggest example is the Cirrus/Wolfson Arizona drivers and the
> wm_adsp DSPs they use. Do you have specific questions around this?

Thanks for your advice. So far, I have no specific questions. First, I will study
Cirrus/Wolfson Arizona drivers and then find a suitable solution for tas2563/tas2781.