From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00F78277029 for ; Wed, 6 May 2026 21:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778102336; cv=none; b=JMxbni6jgoIVQI9JjxZxOvjDpvQaYuwnWPQN+MJLDugYJGPBsYoQzewEEdOZ6gX7N4Pgf1XnMB//ECH8fklxgXF2rjHOqT99ymnr9vykiaR015WBQOHVYVRBoT2ljHUg0bhekVtBqRs89Wfs9+oOWWAmgRL3LsTzaMljCk6Cjk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778102336; c=relaxed/simple; bh=1u1NtmsaEYLuVMoVkP/uqgb7UJCHlWmjT/NLBXYDpbo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=sYhU3bsnRPzflfLEWa9ncIkXHZ2fv7Wwq9pKv8MhDEBjoPc3mePGzzzSeuu9TD5ebeC+LRgjG/BCRO68EQfOaW90+q28+P5OjNSlW1U7C4mj6FS6rady0Y4T40gptTcT/txv8kEJ0R2mdHBXn+JR+Sg+o6t4LzNEmd7UI2lOxzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YXgArCPj; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=mM4sLfLb; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YXgArCPj"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="mM4sLfLb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778102334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xacDOFOjQ9ekVgvkJiHHg7tg2db02oJhTxqXK6zBRi0=; b=YXgArCPjJD3E3dpIjfrOuTaJYzGfSIjfBMAZg95zsNL/5EGJBkY70OJTH3nYXU4a+qf2tT 1E45fdirKtf9T30fM1kvvU9ZK572JXSbY61woa9r8QNGMS4kLS1FeJRHDdGBBw1bcAIq7S Fd1uY++7Ap8N76n0bwBWlr1T4NEpZHM= Received: from mail-yx1-f69.google.com (mail-yx1-f69.google.com [74.125.224.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-148-yPmtsQ-kOFiAi8-PIAhGVw-1; Wed, 06 May 2026 17:18:52 -0400 X-MC-Unique: yPmtsQ-kOFiAi8-PIAhGVw-1 X-Mimecast-MFC-AGG-ID: yPmtsQ-kOFiAi8-PIAhGVw_1778102332 Received: by mail-yx1-f69.google.com with SMTP id 956f58d0204a3-651c15e69d7so268783d50.0 for ; Wed, 06 May 2026 14:18:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778102332; x=1778707132; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=xacDOFOjQ9ekVgvkJiHHg7tg2db02oJhTxqXK6zBRi0=; b=mM4sLfLbvP6R73bHaYzHd9lT6aYyFEte0/YlGrpkv44Dl1iIFg+j66EAfDJyJqIFe0 pljD24qXULpyW4R+y6iudww7EcaPZo9h8/f1HzDJu6dx0orDuDfI4bLOtwLlwil0Fqh3 P+C5onl08pDXcGO3TUUC3qcB9N0qEzA0DdkSv5AItsZIWd88fHrLmqO6MRKb6HC+eyUE QH2Tqhi56K9nFeRjsa+Lms9+dYq2LtkBJRVbXahLH8mhebSZ60/g9A5mv5zYA9sNQJd8 RdqfZhVJ0ByGCIrvELy8pSD869o318P14NZOOeQJWdoYpaEmlMJLM/Lt5Xwk4FvT9zOt RTgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778102332; x=1778707132; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xacDOFOjQ9ekVgvkJiHHg7tg2db02oJhTxqXK6zBRi0=; b=MXsu/9bxANxnEOcEAhVE6+ozZVIw6/AXNxVA++Z7gLFL6l5Z7rMbamWnT4cyuH2pNe xo399h7Z4qjdsYths0die4tzW4fyiOvLsr02hFP3lgZkx99hAAgv3Gbcm3X5PHq/mCSQ y5fI3a1AryLqKEL4evTFtSDfockQT1ZvxxaBpicNfgwnWwQKJv0FPWD2PVGx8OJtTc2Q K1TkRXEGnMWSYnFGe+CLpNLjKxNZBtgax5wOv6YhCntPoG0+qidMP4DTY8wbpXE0cG5i AY4SaYT4nu64gddxaJlYOFsdKqxfDPVPiiLtd04ZJn1zoADepkW6RwfUxU31YtsbPVlI m7xw== X-Forwarded-Encrypted: i=1; AFNElJ//GPPMulS+G9bGZ22dJQc/IBlgDjMG9nYDnSZZrlr34WChmuwJf9v7ylWfluid84FTp8AerhUKw9+M+1c=@vger.kernel.org X-Gm-Message-State: AOJu0YxflJB0uQCk1n/mXdqxJOmvKLL715hDYmWsVqsmdxTdVrIdzxA6 h1nEOxxU3uuIA88TF46zaNcHM7O+/dzFl6FJ7A9XFYW8CSN4qry7aFyNMTSwvyZzixdCwTapP3U cb6FjVWK4ayLJm0sAKZcFTGW7l9sZ63gR7z7SSXieOTA77LNOmjC9jwPMeNHZbxSJuA== X-Gm-Gg: AeBDiesAMOmLBqX9AGZK+dcZuE67KzowyJckGXeK9Q1iWqQSzXg1q1YjNgqUAHFaZuJ UdEU6eeSgFVHdoemylvo6uSN9UwcVaxN58AqszP6yzfUdAK90mryR25t5TFKbpDJDJqDU020BRJ hjRJ9hO4kglobPrwn32xibFLraecpf8UIyApV2L00Z0lKU3C83jtvmP/OStTPIB1zvLyAR2iuh7 XExIt80jakSABL+EoGLb1kGbE3V0icTekacyYR6C3mivGJIfmtDS1lZl6we0m8i0A2jviAF5jL9 CcD2Cu/Vpg5aUzGPzzdcGzS/3sKcCpmxV1qbn8xHhDg5AeNj6OUMG6LjIHvMQegAYyK7399h7wo WG5SJgze67jGfrikgqg73BkJGQU+R4RInV93MraDmzTSoNztMtEJslM4tzYBksxA= X-Received: by 2002:a05:690e:4416:10b0:658:9bfb:602d with SMTP id 956f58d0204a3-65c79d976b3mr4416931d50.38.1778102331999; Wed, 06 May 2026 14:18:51 -0700 (PDT) X-Received: by 2002:a05:690e:4416:10b0:658:9bfb:602d with SMTP id 956f58d0204a3-65c79d976b3mr4416912d50.38.1778102331410; Wed, 06 May 2026 14:18:51 -0700 (PDT) Received: from li-4c4c4544-0032-4210-804c-c3c04f423534.ibm.com ([2600:1700:6476:1430::29]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65c7abf5e11sm1645545d50.0.2026.05.06.14.18.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 14:18:50 -0700 (PDT) Message-ID: <9638f0d7f5ca4f8afd1b366cfbe0ebec3149aa9c.camel@redhat.com> Subject: Re: [EXTERNAL] [PATCH v3 04/11] ceph: add diagnostic timeout loop to wait_caps_flush() From: Viacheslav Dubeyko To: Alex Markuze Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, idryomov@gmail.com Date: Wed, 06 May 2026 14:18:50 -0700 In-Reply-To: References: <20260429125206.1512203-1-amarkuze@redhat.com> <20260429125206.1512203-5-amarkuze@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.0 (3.60.0-1.fc44app2) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-05-06 at 14:34 +0300, Alex Markuze wrote: > Hi Slava, >=20 > Integer type for loop counter i >=20 > The counter i tracks the number of 60-second timeout iterations. To > overflow an int it would need roughly 4,000 years of continuous > waiting. In practice, after CEPH_CAP_FLUSH_MAX_DUMP_COUNT (5) > iterations the diagnostics are suppressed and the counter just ticks > silently; nothing indexes on its value after that point. >=20 > I could change it to unsigned int for cleanliness, but it wouldn't > change behavior. Would you prefer that, or do you have a different > concern about the counter? >=20 It is not critical remark. If you believe that we can survive with integer = type, then I am OK with it. Thanks, Slava.