From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Li Wang <wangli.ahau@gmail.com>,
akpm@linux-foundation.org, ljs@kernel.org,
Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, shuah@kernel.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] selftests/mm: respect build verbosity settings for 32/64-bit targets
Date: Thu, 23 Apr 2026 15:38:42 +0200 [thread overview]
Message-ID: <963b4f8e-b1cb-4e80-b14f-04a43fa15e9b@kernel.org> (raw)
In-Reply-To: <20260422080446.26020-2-wangli.ahau@gmail.com>
On 4/22/26 10:04, Li Wang wrote:
> The 32-bit and 64-bit compilation rules invoke $(CC) directly, bypassing
> the $(Q) quiet prefix and $(call msg,...) helper used by the rest of the
> selftests build system. This causes these rules to always print the full
> compiler command line, even when V=0 (the default).
>
> Wrap the commands with $(Q) and $(call msg,CC,,$@) to match the
> convention used by lib.mk, so that quiet and verbose builds behave
> consistently across all targets.
>
> ==== Build logs ====
> ...
> CC merge
> CC rmap
> CC soft-dirty
> gcc -Wall -O2 -I /usr/src/25/tools/testing/selftests/../../..
> -isystem /usr/src/25/tools/testing/selftests/../../../usr/include
> -isystem /usr/src/25/tools/testing/selftests/../../../tools/include/uapi
> -Wunreachable-code -U_FORTIFY_SOURCE -no-pie -D_GNU_SOURCE=
> -I/usr/src/25/tools/testing/selftests/../../../tools/testing/selftests
> -m32 -mxsave protection_keys.c vm_util.c thp_settings.c pkey_util.c
> -lrt -lpthread -lm -lrt -ldl -lm
> -o /usr/src/25/tools/testing/selftests/mm/protection_keys_32
> gcc -Wall -O2 -I /usr/src/25/tools/testing/selftests/../../..
> -isystem /usr/src/25/tools/testing/selftests/../../../usr/include
> -isystem /usr/src/25/tools/testing/selftests/../../../tools/include/uapi
> -Wunreachable-code -U_FORTIFY_SOURCE -no-pie -D_GNU_SOURCE=
> -I/usr/src/25/tools/testing/selftests/../../../tools/testing/selftests
> -m32 -mxsave pkey_sighandler_tests.c vm_util.c thp_settings.c pkey_util.c
> -lrt -lpthread -lm -lrt -ldl -lm
> -o /usr/src/25/tools/testing/selftests/mm/pkey_sighandler_tests_32
> ...
>
> Reported-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Li Wang <wangli.ahau@gmail.com>
> Tested-by: Andrew Morton <akpm@linux-foundation.org>
> ---
Great
Tested-by: David Hildenbrand (Arm) <david@kernel.org>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-04-23 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 8:04 [PATCH v3 0/2] selftests/mm: clean up build output and verbosity Li Wang
2026-04-22 8:04 ` [PATCH v3 1/2] selftests/mm: respect build verbosity settings for 32/64-bit targets Li Wang
2026-04-23 13:38 ` David Hildenbrand (Arm) [this message]
2026-04-22 8:04 ` [PATCH v3 2/2] selftests/mm: suppress compiler error in liburing check Li Wang
2026-04-23 13:40 ` David Hildenbrand (Arm)
2026-04-23 13:31 ` [PATCH v3 0/2] selftests/mm: clean up build output and verbosity David Hildenbrand (Arm)
2026-04-24 0:17 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=963b4f8e-b1cb-4e80-b14f-04a43fa15e9b@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=wangli.ahau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox