From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751279AbdAPP4w (ORCPT ); Mon, 16 Jan 2017 10:56:52 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:51144 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbdAPP4s (ORCPT ); Mon, 16 Jan 2017 10:56:48 -0500 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: John Stultz , lkml , Wolfram Sang Subject: Re: [PATCH 0/5 v3] adv7511 EDID probing improvements Date: Mon, 16 Jan 2017 17:57:02 +0200 Message-ID: <9649749.TAVrhOzo15@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1483472502-16403-1-git-send-email-john.stultz@linaro.org> References: <1483472502-16403-1-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, Thank you for the patches. On Tuesday 03 Jan 2017 11:41:37 John Stultz wrote: > Hope everyone had a good newyears! > > Wanted to re-send out v3 of this patch set improving the EDID > probing on the adv7511 used on HiKey, for consideration for > merging for 4.11 > > The first three patches are fixups that are hopefully straight > forward, integrating feedback I got from Laurant. > > The last two patches try to clean up and resue code, which as > a side effect avoids an issue I'm seeing where something is > going wrong with the regmap cache state for the > ADV7511_REG_EDID_I2C_ADDR(0x43) register which results in > i2c_transfer errors if we don't do the > regcache_sync/_mark_dirty() calls. I suspect there might be a > better solution there, but have not gotten any other suggestions > so I wanted to go ahead and submit these. > > Thoughts and feedback would be appreciated! For the whole series, Tested-by: Laurent Pinchart > New in v3: > * Addressed naming improvements and drm_kms_helper_hotplug_event > usage corrections as suggested by Laurent. > > Cc: David Airlie > Cc: Archit Taneja > Cc: Wolfram Sang > Cc: Lars-Peter Clausen > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > > Archit Taneja (1): > drm/bridge: adv7511: Enable HPD interrupts to support hotplug and > improve monitor detection > > John Stultz (4): > drm/bridge: adv7511: Use work_struct to defer hotplug handing to out > of irq context > drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event() > drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be > reused internally > drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID > > drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 + > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 62 > +++++++++++++++++++--------- 2 files changed, 44 insertions(+), 20 > deletions(-) -- Regards, Laurent Pinchart