From: Luben Tuikov <ltuikov@yahoo.com>
To: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
Cc: Greg KH <greg@kroah.com>,
linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [USB] Allow retrieval of the Caching mode page
Date: Thu, 21 Oct 2010 21:06:47 -0700 (PDT) [thread overview]
Message-ID: <965283.41083.qm@web31805.mail.mud.yahoo.com> (raw)
In-Reply-To: <20101022000405.GC25431@one-eyed-alien.net>
--- On Thu, 10/21/10, Matthew Dharm <mdharm-kernel@one-eyed-alien.net> wrote:
> If you remove this, there are several devices which will
> stop working.
> They will simply go out-to-lunch when the sd_mod driver
> sends a request for
> Mode Page 8.
That's true. But it seems unfair to punish good devices which do support
the Caching mode page.
sd_revalidate_disk() calls in succession sd_read_write_protect_flag(),
sd_read_cache_type() and sd_read_app_tag_own(). The first, asks for all
pages by setting the page code to 0x3F. Surely if the device server
supports the Caching mode page, it will be returned. The second call, asks
only for the Caching mode page, and here is where some (few?) broken
devices fail.
If the skip_ms_page_8 is set, why not request all pages, and see if the
Caching mode page is part of the parameter data.
Anyone willing to code that up in sd_read_cache_type()?
prev parent reply other threads:[~2010-10-22 4:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 22:52 [PATCH] [USB] Allow retrieval of the Caching mode page Luben Tuikov
2010-10-22 0:04 ` Matthew Dharm
2010-10-22 4:06 ` Luben Tuikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=965283.41083.qm@web31805.mail.mud.yahoo.com \
--to=ltuikov@yahoo.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-kernel@one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox