From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org, akpm@osdl.org
Cc: Benoit Boissinot <bboissin@gmail.com>,
Michael A Halcrow <mahalcro@us.ibm.com>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Keys: Fix request_key default keyring handling
Date: Fri, 01 Apr 2005 16:30:41 +0100 [thread overview]
Message-ID: <9667.1112369441@redhat.com> (raw)
In-Reply-To: <40f323d0050331115016b707f1@mail.gmail.com>
The attached patch fixes the way request_key handles the default destination
key when it's the group keyring. It also removes the check for the no-change
default keyring spec, which shouldn't appear in the task_struct::jit_keyring
member (it's purely for getting the old value from the keyctl function).
Signed-Off-By: Benoit Boissinot <benoit.boissinot@ens-lyon.org>
Signed-Off-By: David Howells <dhowells@redhat.com>
---
warthog>diffstat -p1 /tmp/keys.patch
security/keys/keyctl.c | 2 +-
security/keys/request_key.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
--- ./security/keys/request_key.c.orig 2005-03-31 21:23:43.000000000 +0200
+++ ./security/keys/request_key.c 2005-03-31 21:41:03.000000000 +0200
@@ -335,8 +335,7 @@ static void request_key_link(struct key
dest_keyring = current->user->uid_keyring;
break;
- case KEY_REQKEY_DEFL_NO_CHANGE:
- case KEY_SPEC_GROUP_KEYRING:
+ case KEY_REQKEY_DEFL_GROUP_KEYRING:
default:
BUG();
}
--- ./security/keys/keyctl.c.orig 2005-03-31 21:41:35.000000000 +0200
+++ ./security/keys/keyctl.c 2005-03-31 21:42:01.000000000 +0200
@@ -951,7 +951,7 @@ long keyctl_set_reqkey_keyring(int reqke
case KEY_REQKEY_DEFL_NO_CHANGE:
return current->jit_keyring;
- case KEY_SPEC_GROUP_KEYRING:
+ case KEY_REQKEY_DEFL_GROUP_KEYRING:
default:
return -EINVAL;
}
next prev parent reply other threads:[~2005-04-01 15:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 20:14 [PATCH 1/3] Keys: Pass session keyring to call_usermodehelper() David Howells
2005-03-23 20:19 ` [PATCH 2/3] Keys: Use RCU to manage session keyring pointer David Howells
2005-03-23 21:07 ` Andrew Morton
2005-03-23 21:28 ` David Howells
2005-03-23 20:52 ` [PATCH 3/3] Keys: Make request-key create an authorisation key David Howells
2005-03-24 11:41 ` [PATCH 3/3] Keys: Make request-key create an authorisation key [try #2] David Howells
2005-03-31 19:50 ` [PATCH 3/3] Keys: Make request-key create an authorisation key Benoit Boissinot
2005-04-01 15:30 ` David Howells [this message]
2005-03-23 20:55 ` [PATCH 2/3] Keys: Use RCU to manage session keyring pointer David Howells
2005-04-11 22:45 ` Paul E. McKenney
2005-04-12 9:11 ` David Howells
2005-04-12 14:50 ` Paul E. McKenney
2005-03-23 21:06 ` [PATCH 1/3] Keys: Pass session keyring to call_usermodehelper() Andrew Morton
2005-03-23 21:26 ` David Howells
2005-03-23 22:34 ` Andrew Morton
2005-03-23 22:49 ` David Howells
2005-03-24 0:58 ` Kyle Moffett
2005-03-23 22:25 ` Mike Waychison
2005-03-24 11:38 ` [PATCH 1/3] Keys: Pass session keyring to call_usermodehelper() [try #2] David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9667.1112369441@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=bboissin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahalcro@us.ibm.com \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox