public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* fs cache patch breaks sparc build in 2.6.18-rc4-mm2
@ 2006-08-24 20:15 Paul Jackson
  2006-08-24 20:24 ` David Howells
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Jackson @ 2006-08-24 20:15 UTC (permalink / raw)
  To: linux-kernel; +Cc: David Howells, Trond Myklebust, Andrew Morton

The 2.6.18-rc4-mm2 patch:
    fs-cache-make-kafs-use-fs-cache.patch

seems to break the arch=sparc defconfig build, failing with:

  CC [M]  fs/afs/file.o
fs/afs/file.c: In function `afs_file_releasepage':
fs/afs/file.c:332: error: structure has no member named `cache'
make[2]: *** [fs/afs/file.o] Error 1

Looking at line numbers 326-337 in the file fs/afs/file.c, I see:

326             /* deny */
327             if (PageFsMisc(page)) {
328                     _leave(" = F");
329                     return 0;
330             }
331
332             fscache_uncache_page(AFS_FS_I(page->mapping->host)->cache, page);
333
334             /* indicate that the page can be released */
335             _leave(" = T");
336             return 1;
337     }

So this does seem to be the line 332 the compile is complaining about.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: fs cache patch breaks sparc build in 2.6.18-rc4-mm2
  2006-08-24 20:15 fs cache patch breaks sparc build in 2.6.18-rc4-mm2 Paul Jackson
@ 2006-08-24 20:24 ` David Howells
  0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2006-08-24 20:24 UTC (permalink / raw)
  To: Paul Jackson; +Cc: linux-kernel, David Howells, Trond Myklebust, Andrew Morton

Paul Jackson <pj@sgi.com> wrote:

> Looking at line numbers 326-337 in the file fs/afs/file.c, I see:

Andrew has a patch for that (fs-cache-make-kafs-use-fs-cache-12-fix.patch).

David

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-08-24 20:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-24 20:15 fs cache patch breaks sparc build in 2.6.18-rc4-mm2 Paul Jackson
2006-08-24 20:24 ` David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox