From: Randy Dunlap <rdunlap@infradead.org>
To: Chin-Chun Chen <chinchunchen2001@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include/linux/bitops.h: Fix function fns
Date: Fri, 12 Apr 2024 22:39:23 -0700 [thread overview]
Message-ID: <96b7f74b-548c-451c-b08e-86173db2e40a@infradead.org> (raw)
In-Reply-To: <20240413052850.9419-1-chinchunchen2001@gmail.com>
On 4/12/24 10:28 PM, Chin-Chun Chen wrote:
> Modified the function fns to resolve a calculation error by:
> 1. Reducing n first.
> 2. Adding 1 at the end to get the correct index.
>
> This commit improves the accuracy and reliability of the code.
>
> Signed-off-by: Chin-Chun Chen <chinchunchen2001@gmail.com>
> ---
> include/linux/bitops.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> index 2ba557e067fe..2457610f74eb 100644
> --- a/include/linux/bitops.h
> +++ b/include/linux/bitops.h
> @@ -258,8 +258,8 @@ static inline unsigned long fns(unsigned long word, unsigned int n)
>
> while (word) {
> bit = __ffs(word);
> - if (n-- == 0)
> - return bit;
> + if (--n == 0)
> + return bit + 1;
> __clear_bit(bit, &word);
> }
>
>
> base-commit: 8f2c057754b25075aa3da132cd4fd4478cdab854
Hi,
Please send your patch to some maintainer.
People don't browse the mailing list for patches to pick up.
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
next prev parent reply other threads:[~2024-04-13 5:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 5:28 [PATCH] include/linux/bitops.h: Fix function fns Chin-Chun Chen
2024-04-13 5:39 ` Randy Dunlap [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-13 6:12 Chin-Chun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96b7f74b-548c-451c-b08e-86173db2e40a@infradead.org \
--to=rdunlap@infradead.org \
--cc=chinchunchen2001@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).