From: Florian Fainelli <f.fainelli@gmail.com>
To: Doug Berger <opendmb@gmail.com>, "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/3] net: bcmgenet: test RBUF_ACPI_EN when resuming
Date: Thu, 16 Jul 2020 17:37:20 -0700 [thread overview]
Message-ID: <96c80a48-ab9e-155b-6d6c-913f38f6b3bf@gmail.com> (raw)
In-Reply-To: <1594942697-37954-3-git-send-email-opendmb@gmail.com>
On 7/16/2020 4:38 PM, Doug Berger wrote:
> When the GENET driver resumes from deep sleep the UMAC_CMD
> register may not be accessible and therefore should not be
> accessed from bcmgenet_wol_power_up_cfg() if the GENET has
> been reset.
>
> This commit adds a check of the RBUF_ACPI_EN flag when Wake
> on Filter is enabled. A clear flag indicates that the GENET
> hardware must have been reset so the remainder of the
> hardware programming is bypassed.
>
> Fixes: f50932cca632 ("net: bcmgenet: add WAKE_FILTER support")
> Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-07-17 0:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 23:38 [PATCH net 0/3] net: bcmgenet: fix WAKE_FILTER resume from deep sleep Doug Berger
2020-07-16 23:38 ` [PATCH net 1/3] net: bcmgenet: test MPD_EN when resuming Doug Berger
2020-07-17 0:36 ` Florian Fainelli
2020-07-16 23:38 ` [PATCH net 2/3] net: bcmgenet: test RBUF_ACPI_EN " Doug Berger
2020-07-17 0:37 ` Florian Fainelli [this message]
2020-07-16 23:38 ` [PATCH net 3/3] net: bcmgenet: restore HFB filters on resume Doug Berger
2020-07-17 16:34 ` Florian Fainelli
2020-07-17 20:00 ` [PATCH net 0/3] net: bcmgenet: fix WAKE_FILTER resume from deep sleep David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96c80a48-ab9e-155b-6d6c-913f38f6b3bf@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox