From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Christian Loehle <christian.loehle@arm.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
rafael@kernel.org
Cc: vincent.guittot@linaro.org, qyousef@layalina.io,
peterz@infradead.org, daniel.lezcano@linaro.org,
anna-maria@linutronix.de, kajetan.puchalski@arm.com,
lukasz.luba@arm.com
Subject: Re: [PATCH 5/6] cpuidle: teo: Remove recent intercepts metric
Date: Fri, 7 Jun 2024 10:57:10 +0200 [thread overview]
Message-ID: <96eb4e13-e1c7-4c64-a4bf-0d2b5610d390@arm.com> (raw)
In-Reply-To: <20240606090050.327614-6-christian.loehle@arm.com>
On 06/06/2024 11:00, Christian Loehle wrote:
> The logic for recent intercepts didn't work, there is an underflow
> that can be observed during boot already, which teo usually doesn't
> recover from, making the entire logic pointless.
Is this related to:
https://lkml.kernel.org/r/0ce2d536-1125-4df8-9a5b-0d5e389cd8af@arm.com ?
In this case, a link here would be helpful to get the story.
> Furthermore the recent intercepts also were never reset, thus not
> actually being very 'recent'.
>
> If it turns out to be necessary to focus more heavily on resets, the
> intercepts metric also could be adjusted to decay more quickly.
>
> Fixes: 77577558f25d ("cpuidle: teo: Rework most recent idle duration values treatment")
> Signed-off-by: Christian Loehle <christian.loehle@arm.com>
[...]
next prev parent reply other threads:[~2024-06-07 8:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 9:00 [PATCH 0/6] cpuidle: teo: fixes and improvements Christian Loehle
2024-06-06 9:00 ` [PATCH 1/6] cpuidle: teo: Increase util-threshold Christian Loehle
2024-06-07 8:01 ` Dietmar Eggemann
2024-06-07 9:35 ` Christian Loehle
2024-06-09 22:47 ` Qais Yousef
2024-06-10 9:11 ` Christian Loehle
2024-06-16 21:54 ` Qais Yousef
2024-06-10 9:57 ` Ulf Hansson
2024-06-16 21:50 ` Qais Yousef
2024-06-19 9:53 ` Christian Loehle
2024-06-06 9:00 ` [PATCH 2/6] cpuidle: teo: Don't stop tick on utilized Christian Loehle
2024-06-06 9:00 ` [PATCH 3/6] cpuidle: teo: Don't always stop tick on one state Christian Loehle
2024-06-06 9:00 ` [PATCH 4/6] cpuidle: teo: Increase minimum time to stop tick Christian Loehle
2024-06-07 8:14 ` Dietmar Eggemann
2024-06-07 9:29 ` Christian Loehle
2024-06-06 9:00 ` [PATCH 5/6] cpuidle: teo: Remove recent intercepts metric Christian Loehle
2024-06-07 8:57 ` Dietmar Eggemann [this message]
2024-06-07 9:26 ` Christian Loehle
2024-06-06 9:00 ` [PATCH 6/6] cpuidle: teo: Don't count non-existent intercepts Christian Loehle
2024-06-07 10:17 ` Dietmar Eggemann
2024-06-10 11:06 ` Christian Loehle
2024-06-06 11:54 ` [PATCH 0/6] cpuidle: teo: fixes and improvements Christian Loehle
2024-06-06 12:29 ` Rafael J. Wysocki
2024-06-06 12:36 ` Christian Loehle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96eb4e13-e1c7-4c64-a4bf-0d2b5610d390@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=anna-maria@linutronix.de \
--cc=christian.loehle@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=kajetan.puchalski@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rafael@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox