From: Chris Mason <mason@suse.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>,
Andrew Morton <akpm@zip.com.au>
Cc: Linus Torvalds <torvalds@transmeta.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] smarter atime updates
Date: Fri, 30 Nov 2001 12:29:39 -0500 [thread overview]
Message-ID: <970480000.1007141379@tiny> (raw)
In-Reply-To: <Pine.LNX.4.21.0111301344330.17515-100000@freak.distro.conectiva>
In-Reply-To: <Pine.LNX.4.21.0111301344330.17515-100000@freak.distro.conectiva>
On Friday, November 30, 2001 01:44:42 PM -0200 Marcelo Tosatti
<marcelo@conectiva.com.br> wrote:
>
> Now are you sure this can't break anything ?
>
It shouldn't hurt reiserfs at least, I like it.
-chris
> On Thu, 29 Nov 2001, Andrew Morton wrote:
>
>> mark_inode_dirty() is quite expensive for journalling filesystems,
>> and we're calling it a lot more than we need to.
>>
>> --- linux-2.4.17-pre1/fs/inode.c Mon Nov 26 11:52:07 2001
>> +++ linux-akpm/fs/inode.c Thu Nov 29 21:53:02 2001
>> @@ -1187,6 +1187,8 @@ void __init inode_init(unsigned long mem
>>
>> void update_atime (struct inode *inode)
>> {
>> + if (inode->i_atime == CURRENT_TIME)
>> + return;
>> if ( IS_NOATIME (inode) ) return;
>> if ( IS_NODIRATIME (inode) && S_ISDIR (inode->i_mode) ) return;
>> if ( IS_RDONLY (inode) ) return;
>>
>>
>> with this patch, the time to read a 10 meg file with 10 million
>> read()s falls from 38 seconds (ext3), 39 seconds (reiserfs) and
>> 11.6 seconds (ext2) down to 10.5 seconds.
next prev parent reply other threads:[~2001-11-30 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-30 6:08 [patch] smarter atime updates Andrew Morton
2001-11-30 9:45 ` OGAWA Hirofumi
2001-11-30 9:56 ` Andrew Morton
2001-11-30 10:40 ` OGAWA Hirofumi
2001-11-30 22:34 ` H. Peter Anvin
2001-11-30 15:44 ` Marcelo Tosatti
2001-11-30 17:29 ` Chris Mason [this message]
2001-11-30 20:03 ` Robert Love
2001-11-30 21:52 ` Andreas Dilger
2001-11-30 21:50 ` Linus Torvalds
2001-11-30 22:30 ` Simon Kirby
2001-11-30 23:31 ` H. Peter Anvin
2001-12-01 9:22 ` Hans Reiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=970480000.1007141379@tiny \
--to=mason@suse.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox