From: Zhang Rui <rui.zhang@intel.com>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: intel: fix unmatched pci_release_region
Date: Thu, 16 Jan 2020 14:57:10 +0800 [thread overview]
Message-ID: <970ad09ea5ef05ca5bf158fdb9e5c9596e746fc5.camel@intel.com> (raw)
In-Reply-To: <20191206075531.18637-1-hslester96@gmail.com>
On Fri, 2019-12-06 at 15:55 +0800, Chuhong Yuan wrote:
> The driver calls pci_request_regions() in probe and uses
> pci_release_regions() in probe failure.
> However, it calls pci_release_region() in remove, which does
> match the other two calls.
> Use pci_release_regions() instead to unify them.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
> ---
> drivers/thermal/intel/intel_pch_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/intel_pch_thermal.c
> b/drivers/thermal/intel/intel_pch_thermal.c
> index 4f0bb8f502e1..5f7798b8d35f 100644
> --- a/drivers/thermal/intel/intel_pch_thermal.c
> +++ b/drivers/thermal/intel/intel_pch_thermal.c
> @@ -365,7 +365,7 @@ static void intel_pch_thermal_remove(struct
> pci_dev *pdev)
> thermal_zone_device_unregister(ptd->tzd);
> iounmap(ptd->hw_base);
> pci_set_drvdata(pdev, NULL);
> - pci_release_region(pdev, 0);
> + pci_release_regions(pdev);
> pci_disable_device(pdev);
> }
>
prev parent reply other threads:[~2020-01-16 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 7:55 [PATCH] thermal: intel: fix unmatched pci_release_region Chuhong Yuan
2019-12-09 15:42 ` Daniel Lezcano
2020-01-16 6:57 ` Zhang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=970ad09ea5ef05ca5bf158fdb9e5c9596e746fc5.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=hslester96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox