Re: [PATCH] math-emu/setcc: avoid gcc extension

Robert P. J. Day
2007-01-07T19:28:12Z

On Sun, 7 Jan 2007, Randy Dunlap wrote:

> On Sun, 7 Jan 2007 20:12:42 +0100 Segher Boessenkool wrote:
>
> > There's an extra tab in that last line. Could you also
> > please fix the indenting (use a tab, not spaces) -- I know
> > it was there originally, but since there are only a few
> > lines in that file like that... :-)
>
> how's this one?
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> setcc() in math-emu is written as a gcc extension statement
> expression macro that returns a value. However, it's not used that
> way and it's not needed like that, so just make it a do-while
> non-extension macro so that we don't use an extension when it's not
> needed.

is that the proposed coding style for macros? if it returns a value,
use "({ })"? if not, use the "do ... while" notation?

rday