From: Markus Elfring <Markus.Elfring@web.de>
To: Wang YanQing <udknight@gmail.com>, Joe Perches <joe@perches.com>,
Andy Whitcroft <apw@canonical.com>,
kernel-janitors@vger.kernel.org, linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Matteo Croce <mcroce@redhat.com>
Subject: Re: [v4] checkpatch: add support to check 'Fixes:' tag format
Date: Sun, 3 May 2020 14:32:26 +0200 [thread overview]
Message-ID: <975e6172-b333-37ab-ccc7-9e9a85986dfe@web.de> (raw)
In-Reply-To: <20200503114557.GA10332@udknight>
>>> + $diagnostics .= "Missing a pair of parentheses '()' or a pair of double quotation marks (\"\").\n";
>>
>> Can such a message trigger any more thoughts and development ideas?
>
> No, I don't think so. '(" ... ")' is the minimum interface between analyser
> (checkpatch) and commit id description (normal commit id and 'Fixes:' tag)
* I am proposing to recheck the influence of quotation character alternatives
also at this place.
* How do you think about to provide an information without the word “or”
in error messages?
> about the title, it is very difficult if not impossible to guess the title
> boundary and whether it is the *REAL* title that folllow the SHA1 without
> this precondition,
I find this concern reasonable.
> and it is more difficult to do it when we need to support
> title which across lines in the normal commit id description.
I imagine that further software design options can be considered.
> At last I really doubt the benefit it brings deserves the complexity and the
> current diagnostics info is enough clear for most situation.
* Will a safer data format description trigger corresponding efforts?
* Will the structure of the commit title matter?
* Would you like to improve checks (and program organisation) besides
the application of regular expressions?
Regards,
Markus
prev parent reply other threads:[~2020-05-03 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 18:54 [PATCH v4] checkpatch: add support to check 'Fixes:' tag format Wang YanQing
2020-05-02 19:40 ` Markus Elfring
2020-05-02 20:00 ` Joe Perches
2020-05-02 20:07 ` [v4] " Markus Elfring
2020-05-03 11:45 ` [PATCH v4] " Wang YanQing
2020-05-03 12:32 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=975e6172-b333-37ab-ccc7-9e9a85986dfe@web.de \
--to=markus.elfring@web.de \
--cc=alexei.starovoitov@gmail.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox