From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 947561DE4CD; Tue, 8 Oct 2024 13:12:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728393151; cv=none; b=ato5m8cc7tk1QFiYs8oACd3dj70pvyLLoIzvU7ggh8E+LYJIdLUvHM9Q9dVI9I2y0gi8dzFKj+lDbnqE5lwfsx/yPeVSZMoymYxQ8ZU8Bc2fcUYEJ4hMdotcENcmAmeqgIzP9iVMVG3GrAqhEUcQ4WEsKwm2au59e1aXrTxvMww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728393151; c=relaxed/simple; bh=XNJg90BcPtOh5bOTDEKFgeZnHPnV0Mgej+wWmD0tL+Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R0MfiIv2V8tTaOzBtJZ86XKI/qd/j3/bdtk87bzvTC9HdBFQLmePwZebiI7Ko7TEqCKAZlPi82zSKSHxfdir+FWsmn3IeJ0y2X9guphxTTz0pkimLNkhd2DvYHaehb+aVEN9X17rNLtO8RqPPkBvtGuFjC9Cg+WCtyD258tjsWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=AAKLZgdF; arc=none smtp.client-ip=115.124.30.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="AAKLZgdF" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1728393146; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=L2tMYa++LilgFGUn5qa+f4HeMfwMqFzOdCyNTGH96cU=; b=AAKLZgdF83PdF5jp4cbgn0tYkATeuuTSGnoZOj681gis+wRNNY9VHPp3TLoyfVnBvci23PieHXLwzgt0C/Rolztz3xS+saWLqpnidMFkzAXypfApfwbWDjZTfnBPZ2vFIF+ORX4fGmvKescmKJZylEORkX2kfU0hjh9Y0DY0jjI= Received: from 192.168.2.29(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WGfRSit_1728393144) by smtp.aliyun-inc.com; Tue, 08 Oct 2024 21:12:25 +0800 Message-ID: <9774de2b-2bd6-443e-b502-2c1dd3ccf0a8@linux.alibaba.com> Date: Tue, 8 Oct 2024 21:12:23 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] fs/super.c: introduce get_tree_bdev_by_dev() To: Christoph Hellwig Cc: Christian Brauner , Alexander Viro , Jan Kara , Allison Karlitskaya , Chao Yu , LKML , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org References: <20241008095606.990466-1-hsiangkao@linux.alibaba.com> <34cbdb0b-28f4-4408-83b1-198f55427b5c@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/10/8 20:55, Christoph Hellwig wrote: > On Tue, Oct 08, 2024 at 08:33:27PM +0800, Gao Xiang wrote: >> how about >> int get_tree_bdev_flags(struct fs_context *fc, >> int (*fill_super)(struct super_block *, >> struct fs_context *), bool quiet) >> >> for now? it can be turned into `int flags` if other needs >> are shown later (and I don't need to define an enum.) > > I'd pass an unsigned int flags with a clearly spellt out (and > extensible) flags namespae. okay, got it. Thanks, Gao Xiang