From: "Li, Aubrey" <aubrey.li@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
Cc: Aubrey Li <aubrey.li@intel.com>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
ak@linux.intel.com, tim.c.chen@linux.intel.com,
arjan@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1 2/2] proc: add /proc/<pid>/thread_state
Date: Thu, 8 Nov 2018 22:03:06 +0800 [thread overview]
Message-ID: <977bf7ee-deb3-0c9f-def5-7bb04d2e78ae@linux.intel.com> (raw)
In-Reply-To: <20181108101729.GP9761@hirez.programming.kicks-ass.net>
On 2018/11/8 18:17, Peter Zijlstra wrote:
> On Thu, Nov 08, 2018 at 07:32:46AM +0100, Ingo Molnar wrote:
>>
>> * Aubrey Li <aubrey.li@intel.com> wrote:
>>
>>> Expose the per-task cpu specific thread state value, it's helpful
>>> for userland to classify and schedule the tasks by different policies
>>
>> That's pretty vague - what exactly would use this information? I'm sure
>> you have a usecase in mind - could you please describe it?
>
> Yeah, "thread_state" is a pretty terrible name for this.
task_struct has a CPU specific element "thread", I quote it to here to
create a generic interface to expose CPU specific state of the task.
Like /proc/<pid>/stat, I plan to use this "thread_state" to host any CPU
specific state, including AVX state(now only), and any other states(may come
soon). So this interface may be extended in future like the following:
#cat /proc/<pid>/thread_state
1 0 0
>
The use-case is
> detectoring which tasks use AVX3 such that a userspace component (think
> job scheduler) can cluster them together.>
> The 'problem' is that running AVX2+ code drops the max clock, because
> you light up the massive wide (and thus large area) paths.
Thanks to explain this.
>
> So maybe something like "simd_active" is a better name, dunno.
As above, maybe the name can be hidden by thread_state?
>
> Or maybe "simd_class" and we can write out 0,1,2,3 depending on the AVX
> class being used, dunno. It might make sense to look at what other arch
> SIMD stuff looks like to form this interface.
>
A task may use 1,2,3 simultaneously, as a scheduler hint, it's just cluster
or not, so 0/1 may be good enough.
Thanks,
-Aubrey
next prev parent reply other threads:[~2018-11-08 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 18:23 [RFC PATCH v1 1/2] x86/fpu: detect AVX task Aubrey Li
2018-11-06 18:23 ` [RFC PATCH v1 2/2] proc: add /proc/<pid>/thread_state Aubrey Li
2018-11-08 6:32 ` Ingo Molnar
2018-11-08 10:17 ` Peter Zijlstra
2018-11-08 14:03 ` Li, Aubrey [this message]
2018-11-12 5:31 ` Ingo Molnar
2018-11-12 7:53 ` Li, Aubrey
2018-11-12 8:56 ` Peter Zijlstra
2018-11-12 14:21 ` Arjan van de Ven
2018-11-07 17:41 ` [RFC PATCH v1 1/2] x86/fpu: detect AVX task Tim Chen
2018-11-08 0:31 ` Li, Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=977bf7ee-deb3-0c9f-def5-7bb04d2e78ae@linux.intel.com \
--to=aubrey.li@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=aubrey.li@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox