From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
LMML <linux-media@vger.kernel.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] media: davinci: vpif: remove unwanted header mach/hardware.h and sort the includes alphabetically
Date: Sun, 26 May 2013 02:49:37 +0200 [thread overview]
Message-ID: <97825926.dhHpFOhUhr@avalon> (raw)
In-Reply-To: <1369499796-18762-2-git-send-email-prabhakar.csengg@gmail.com>
Hi Prabhakar,
Thank you for the patch.
On Saturday 25 May 2013 22:06:32 Prabhakar Lad wrote:
> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>
> This patch removes unwanted header include of mach/hardware.h
> and along side sorts the header inclusion alphabetically.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/davinci/vpif.c | 10 ++++------
> 1 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/davinci/vpif.c
> b/drivers/media/platform/davinci/vpif.c index ea82a8b..761c825 100644
> --- a/drivers/media/platform/davinci/vpif.c
> +++ b/drivers/media/platform/davinci/vpif.c
> @@ -17,18 +17,16 @@
> * GNU General Public License for more details.
> */
>
> +#include <linux/err.h>
> #include <linux/init.h>
> +#include <linux/io.h>
> +#include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <linux/spinlock.h>
> -#include <linux/kernel.h>
> -#include <linux/io.h>
> -#include <linux/err.h>
> #include <linux/pm_runtime.h>
> +#include <linux/spinlock.h>
> #include <linux/v4l2-dv-timings.h>
>
> -#include <mach/hardware.h>
> -
> #include "vpif.h"
>
> MODULE_DESCRIPTION("TI DaVinci Video Port Interface driver");
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-05-26 0:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 16:36 [PATCH v2 0/5] media: davinci: vpif trivial cleanup Prabhakar Lad
2013-05-25 16:36 ` [PATCH v2 1/5] media: davinci: vpif: remove unwanted header mach/hardware.h and sort the includes alphabetically Prabhakar Lad
2013-05-26 0:49 ` Laurent Pinchart [this message]
2013-05-25 16:36 ` [PATCH v2 2/5] media: davinci: vpif: Convert to devm_* api Prabhakar Lad
2013-05-26 0:49 ` Laurent Pinchart
2013-05-26 14:15 ` Sergei Shtylyov
2013-05-29 1:12 ` Laurent Pinchart
2013-05-25 16:36 ` [PATCH v2 3/5] media: davinci: vpif: remove unnecessary braces around defines Prabhakar Lad
2013-05-26 0:51 ` Laurent Pinchart
2013-05-25 16:36 ` [PATCH v2 4/5] media: davinci: vpif_capture: Convert to devm_* api Prabhakar Lad
2013-05-26 1:14 ` Laurent Pinchart
2013-05-25 16:36 ` [PATCH v2 5/5] media: davinci: vpif_display: " Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97825926.dhHpFOhUhr@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox