public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: BUG in 2.6.22-rc2-mm1: NIC module b44.c broken (Broadcom 4400)
@ 2007-05-27 10:46 Uwe Bugla
  2007-05-27 13:41 ` Kyle Moffett
  0 siblings, 1 reply; 54+ messages in thread
From: Uwe Bugla @ 2007-05-27 10:46 UTC (permalink / raw)
  To: Dan Williams
  Cc: Andrew Morton, Larry Finger, linux-kernel, linux-wireless,
	Maximilian Engelhardt, Michael Buesch

Am Samstag, 26. Mai 2007 23:52 schrieben Sie:
> On Sat, 2007-05-26 at 23:32 +0200, Uwe Bugla wrote:
> > Am Samstag, 26. Mai 2007 21:49 schrieben Sie:
> > > On Saturday 26 May 2007 21:39:54 Uwe Bugla wrote:
> > > > Am Samstag, 26. Mai 2007 21:19 schrieben Sie:
> > > > > Uwe, please try the following patch:
> > > > >
> > > > > Index: bu3sch-wireless-dev/drivers/net/b44.c
> > > > > ===================================================================
> > > > > --- bu3sch-wireless-dev.orig/drivers/net/b44.c        2007-05-18
> > > > > 18:09:50.000000000 +0200 +++
> > > > > bu3sch-wireless-dev/drivers/net/b44.c 2007-05-26 21:18:28.000000000
> > > > > +0200 @@ -2201,10 +2201,12 @@ static int __devinit
> > > > > b44_init_one(struct printk("%2.2x%c", dev->dev_addr[i],
> > > > >                      i == 5 ? '\n' : ':');
> > > > >
> > > > > +#if 0
> > > > >       /* Initialize phy */
> > > > >       spin_lock_irq(&bp->lock);
> > > > >       b44_chip_reset(bp);
> > > > >       spin_unlock_irq(&bp->lock);
> > > > > +#endif
> > > > >
> > > > >       return 0;
> > > >
> > > > Against what kernel please?
> > > > Just try to be a bit more eloquent, man!
> > >
> > > Against a kernel which does not work for you, of course.
> > >
> > > Sometimes I wonder... (no better not say that).
> >
> > YES! And I wonder TOO, definitely!
> >
> > Quand meme (now, if you do not speak french: Above all that), I applied
> > your patch against 2.6.22-rc2-mm1. Just to show my cooperation willing to
> > get your "dream" being fulfilled!
> >
> > Result is: No change!
> > Non-functionable b44-device at all!
> >
> > Hint: Although being a "non-hacker" or "non-developer" I do have stepped
> > across some experienced developer people who at least added some code to
> > make their modules function in the following way:
> >
> > modprobe xyz debug=1 (or debug=2 or debug=3 or debug=4 or debug=5 or
> > debug=6)
> >
> > In so far, if you continue to state that debugging is nothing but
> > guessing around wildly you are definitely wrong, showing us all your
> > missing code hacker experience. If you DO continue like this every step
> > will be a torture not only for me but for the reading folks as well.
> >
> > But every human being is here to learn and develop: In so far I am very
> > optimistic!
> >
> > Apart from the Kconfig chaos that seems to be subordinate in your
> > personal rating scale, you at least could have added some functions like
> > the above mentioned functions.
> >
> > The fact that you simply ignored to imply those functions and continue to
> > call other people dumb shows exactly how small and humble you are.
> >
> > Apart from that:
> > The message that you rooted to my place was no "proof" at all for any
> > kind of disfunctionality or compatibility issue!
> >
> > In that message the lack of performance of the "enclosed" or "old"
> > or "complete" b44 module (i. e. PCI-only module) was criticised, NOT the
> > one ripped by you personally into two modules called b44 and ssb.
> >
> > In so far I would deeply appreciate you personally to stick to the facts
> > in your personal lack of knowledge about the b44 driver instead of
> > playing bad politics against other people like me and others.
> >
> >
> > Hello my dear Andrew Morton,
> >
> > Could you please do me and the rest of the world two favours?
> >
> > A. Rip Michael Buesches code out of the mm-tree
> >
> > B. Give Michael Buesch a fair chance to revise his disfunctionable code
> > outside the mm-tree and / or the vanilla mainline.
> >
> > Side note for the what and why:
> >
> > I like to help avoid dangers by testing the mm-tree.
> > BUT:
> >
> > If real debugging conforms to nothing but guessing around wildly let me
> > tell you that I do not appreciate to be part of that torture due to the
> > lack of experience of some German spare time hacker.
> >
> > A: proven by facts not knowing or even wanting to know how to imply
> > appropriate functionable debug parametres in his driver code
> >
> > B: non-cooperative as far as Kconfig help features are concerned (i. E.
> > help to understand the issues for users
> >
> > C: calling all people simply dumb who do not know about his personal
> > issues at all
> >
> > Thank you, Andrew Morton! You are real fine!
>
> Everyone just needs to cool down.  And you both (Uwe and Michael) just
> need to try debugging the problem.
>
> Abstracting the SSB code into a library is clearly the correct solution,
> rather than having the same code in two separate places.  The whole
> _point_ of having code in various trees (wireless, mm, etc) is to find
> these bugs before the patches hit mainline.  Even testing on > 3
> machines may not uncover subtle bugs (for example, different behavior on
> different silicon revisions, especially in reverse-engineered parts),

yes, and to simplify that you need additional commandline parametres 
(debug=1,2,3,4,5 f. ex.).
Those debug levels provide:
1. different verbose levels of printed output, sent to specific logs like 
kern.log for example
2. different hexadecimal outprints who show what sub-part of the driver is 
working as expected and what part is not
3. if the driver is loaded correctly but refuses to work as expected while 
the "traditional" one without "outsourced" ssb backplane works as expected 
there must be some technique to move the what and why into system logs, just 
to establish facts instead of guessing around.
4. If that technique is not provided by the author of the code then that is a 
proof for the author's lack of experience. As I said already: Too many cooks 
do spoil the pap.

If debugging is limited to dmesg, .config and guessing around, then I call 
such a code a real poor and crude one.

> it's only something Michael can test so far before other people have to
> pick it up and test it.

Theoretically: yes. Practically: No, due to the personal withdraws of the 
latest cook.

Michael in fact thinks that if he is producing code he can delegate everything 
else to other people, replying "for me it works" like a parrot.

In so far, not only the code itself is quite rude and crude, but the author of 
the code is too, transforming the testing procedure into a torture due to the 
author's (i. e. the latest cook's) proven personal and technical 
incompetence. 

> And that's where you come in, Uwe. 

Yes.

>
> So both of you should actually just stop the name-calling, suck it up,
> and debug the problem.  We're getting nothing done here.
>
> Dan

You cannot debug the problem for the reasons that I already described, and I 
will not spend my time with this crude stuff anymore.

My proposal is: Gary Zambrowski should revise that code (the only one Cced 
being employed at broadcom.com, the manufacturer).

Until the job is done by Gary Andrew Morton should rip this stuff out of the 
mm-tree for being rude, crude, immature.

Uwe

_______________________________________________________________
SMS schreiben mit WEB.DE FreeMail - einfach, schnell und
kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192


^ permalink raw reply	[flat|nested] 54+ messages in thread
* BUG in 2.6.22-rc2-mm1: NIC module b44.c broken (Broadcom 4400)
@ 2007-05-24 19:56 Uwe Bugla
  2007-05-24 20:06 ` Andrew Morton
  2007-05-27 20:02 ` Denis Vlasenko
  0 siblings, 2 replies; 54+ messages in thread
From: Uwe Bugla @ 2007-05-24 19:56 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel

Hi everybody,

The patch against b44.c contained in 2.6.22-rc2-mm1 has two consequences:

1. a tight binding to module ssb whose function or necessity I neither see through nor do comprehend

2. a breakdown (disfunctionality) of my onboard NIC.

lspci -v looks like this:

00:00.0 Host bridge: Intel Corporation 82845G/GL[Brookdale-G]/GE/PE DRAM Controller/Host-Hub Interface (rev 02)
	Subsystem: ASUSTeK Computer Inc. Unknown device 80b2
	Flags: bus master, fast devsel, latency 0
	Memory at f8000000 (32-bit, prefetchable) [size=64M]
	Capabilities: [e4] Vendor Specific Information
	Capabilities: [a0] AGP version 2.0

00:01.0 PCI bridge: Intel Corporation 82845G/GL[Brookdale-G]/GE/PE Host-to-AGP Bridge (rev 02) (prog-if 00 [Normal decode])
	Flags: bus master, 66MHz, fast devsel, latency 64
	Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
	I/O behind bridge: 0000d000-0000dfff
	Memory behind bridge: f2000000-f27fffff
	Prefetchable memory behind bridge: f3f00000-f7ffffff

00:1d.0 USB Controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1 (rev 02) (prog-if 00 [UHCI])
	Subsystem: ASUSTeK Computer Inc. Unknown device 8089
	Flags: bus master, medium devsel, latency 0, IRQ 17
	I/O ports at b800 [size=32]

00:1d.1 USB Controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2 (rev 02) (prog-if 00 [UHCI])
	Subsystem: ASUSTeK Computer Inc. Unknown device 8089
	Flags: bus master, medium devsel, latency 0, IRQ 20
	I/O ports at b400 [size=32]

00:1d.2 USB Controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) USB UHCI Controller #3 (rev 02) (prog-if 00 [UHCI])
	Subsystem: ASUSTeK Computer Inc. Unknown device 8089
	Flags: bus master, medium devsel, latency 0, IRQ 16
	I/O ports at b000 [size=32]

00:1d.7 USB Controller: Intel Corporation 82801DB/DBM (ICH4/ICH4-M) USB2 EHCI Controller (rev 02) (prog-if 20 [EHCI])
	Subsystem: ASUSTeK Computer Inc. Unknown device 8089
	Flags: bus master, medium devsel, latency 0, IRQ 18
	Memory at f1800000 (32-bit, non-prefetchable) [size=1K]
	Capabilities: [50] Power Management version 2
	Capabilities: [58] Debug port

00:1e.0 PCI bridge: Intel Corporation 82801 PCI Bridge (rev 82) (prog-if 00 [Normal decode])
	Flags: bus master, fast devsel, latency 0
	Bus: primary=00, secondary=02, subordinate=02, sec-latency=32
	Memory behind bridge: f1000000-f17fffff
	Prefetchable memory behind bridge: f2800000-f3efffff

00:1f.0 ISA bridge: Intel Corporation 82801DB/DBL (ICH4/ICH4-L) LPC Interface Bridge (rev 02)
	Flags: bus master, medium devsel, latency 0

00:1f.1 IDE interface: Intel Corporation 82801DB (ICH4) IDE Controller (rev 02) (prog-if 8a [Master SecP PriP])
	Subsystem: ASUSTeK Computer Inc. Unknown device 8089
	Flags: bus master, medium devsel, latency 0, IRQ 16
	I/O ports at 01f0 [size=8]
	I/O ports at 03f4 [size=1]
	I/O ports at 0170 [size=8]
	I/O ports at 0374 [size=1]
	I/O ports at f000 [size=16]
	Memory at 30000000 (32-bit, non-prefetchable) [size=1K]

00:1f.3 SMBus: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) SMBus Controller (rev 02)
	Subsystem: ASUSTeK Computer Inc. Unknown device 8089
	Flags: medium devsel, IRQ 19
	I/O ports at e800 [size=32]

00:1f.5 Multimedia audio controller: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller (rev 02)
	Subsystem: ASUSTeK Computer Inc. Unknown device 80b0
	Flags: bus master, medium devsel, latency 0, IRQ 19
	I/O ports at a800 [size=256]
	I/O ports at a400 [size=64]
	Memory at f0800000 (32-bit, non-prefetchable) [size=512]
	Memory at f0000000 (32-bit, non-prefetchable) [size=256]
	Capabilities: [50] Power Management version 2

01:00.0 VGA compatible controller: ATI Technologies Inc Rage 128 PF/PRO AGP 4x TMDS (prog-if 00 [VGA])
	Subsystem: ATI Technologies Inc Rage Fury Pro/Xpert 2000 Pro
	Flags: bus master, stepping, 66MHz, medium devsel, latency 64, IRQ 17
	Memory at f4000000 (32-bit, prefetchable) [size=64M]
	I/O ports at d800 [size=256]
	Memory at f2000000 (32-bit, non-prefetchable) [size=16K]
	Expansion ROM at f3fe0000 [disabled] [size=128K]
	Capabilities: [50] AGP version 2.0
	Capabilities: [5c] Power Management version 2

02:05.0 Ethernet controller: Broadcom Corporation BCM4401 100Base-T (rev 01)
	Subsystem: ASUSTeK Computer Inc. A7V8X motherboard
	Flags: bus master, fast devsel, latency 32, IRQ 255
	Memory at f1000000 (32-bit, non-prefetchable) [disabled] [size=8K]
	Capabilities: [40] Power Management version 2

02:0b.0 Multimedia video controller: Brooktree Corporation Bt878 Video Capture (rev 11)
	Subsystem: Pinnacle Systems Inc. PCTV Sat (DBC receiver)
	Flags: bus master, medium devsel, latency 32, IRQ 18
	Memory at f3000000 (32-bit, prefetchable) [size=4K]
	Capabilities: [44] Vital Product Data
	Capabilities: [4c] Power Management version 2

02:0b.1 Multimedia controller: Brooktree Corporation Bt878 Audio Capture (rev 11)
	Subsystem: Pinnacle Systems Inc. PCTV Sat (DBC receiver)
	Flags: bus master, medium devsel, latency 32, IRQ 18
	Memory at f2800000 (32-bit, prefetchable) [size=4K]
	Capabilities: [44] Vital Product Data
	Capabilities: [4c] Power Management version 2

Please note:

1. IRQ 255 looks very idiotic, doesn't it? It does not exist at all, does it?

Questions:

1. What is the technical need / progress of module ssb please?

2. If Andrew Morton's guidelines clearly say: "Do test your patches on three different machines" and this guideline seems to be strictly ignored by some sparetime hackers:

What is the master plan then to avoid the fact that such a crap is being sent in to Andrew?

Yours sincerely

Uwe

P. S.: There is an important saying going like this:

Too many cooks do mess up the pap.

Regarding the patch in mm-tree I can see SIX (!) Copyright owners.
The last one of them (i. e. the one of 2007) obviuosly does not seem to understand what he is doing (see that nonsense interrupt please, just incredible!) :(

In so far I would deeply appreciate Andrew Morton to throw that b44.c patch into the trashbox as soon as possible :)

-- 
Psssst! Schon vom neuen GMX MultiMessenger gehört?
Der kanns mit allen: http://www.gmx.net/de/go/multimessenger

^ permalink raw reply	[flat|nested] 54+ messages in thread

end of thread, other threads:[~2007-05-28 12:14 UTC | newest]

Thread overview: 54+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-27 10:46 BUG in 2.6.22-rc2-mm1: NIC module b44.c broken (Broadcom 4400) Uwe Bugla
2007-05-27 13:41 ` Kyle Moffett
  -- strict thread matches above, loose matches on Subject: below --
2007-05-24 19:56 Uwe Bugla
2007-05-24 20:06 ` Andrew Morton
2007-05-24 21:16   ` Uwe Bugla
2007-05-25 13:16     ` Michael Buesch
2007-05-25 13:12   ` Michael Buesch
2007-05-25 13:20     ` Michael Buesch
2007-05-25 13:59     ` Uwe Bugla
2007-05-25 14:52       ` Michael Buesch
2007-05-25 15:59         ` Uwe Bugla
2007-05-25 16:23           ` Michael Buesch
2007-05-25 18:48           ` Maximilian Engelhardt
2007-05-25 19:40             ` Uwe Bugla
2007-05-26  5:00               ` Michael Buesch
2007-05-26  9:39                 ` Maximilian Engelhardt
2007-05-26 10:40                 ` Uwe Bugla
2007-05-26 15:36                   ` Michael Buesch
2007-05-26 15:52                     ` Uwe Bugla
2007-05-26 15:50                   ` Michael Buesch
2007-05-26 16:13                     ` Andrew Morton
2007-05-26 16:20                       ` Uwe Bugla
2007-05-26 16:46                         ` Francois Romieu
2007-05-26 16:21                       ` Michael Buesch
2007-05-26 16:26                         ` Uwe Bugla
2007-05-26 16:40                           ` Michael Buesch
2007-05-26 17:04                             ` Uwe Bugla
2007-05-26 17:18                               ` Michael Buesch
2007-05-26 17:24                                 ` Uwe Bugla
2007-05-26 18:03                                   ` Michael Buesch
2007-05-26 18:19                                     ` Andrew Morton
2007-05-26 19:38                                       ` Uwe Bugla
2007-05-26 19:57                                         ` Larry Finger
2007-05-26 20:22                                           ` Francois Romieu
2007-05-26 20:33                                           ` Uwe Bugla
2007-05-26 21:00                                             ` Michael Buesch
2007-05-26 18:41                                 ` Benoit Boissinot
2007-05-26 18:46                                   ` Michael Buesch
2007-05-26 18:58                                   ` Uwe Bugla
2007-05-26 19:14                                     ` Michael Buesch
2007-05-26 19:19                                     ` Michael Buesch
2007-05-26 19:39                                       ` Uwe Bugla
2007-05-26 19:49                                         ` Michael Buesch
2007-05-26 21:32                                           ` Uwe Bugla
2007-05-26 21:52                                             ` Dan Williams
2007-05-26 22:16                                               ` Uwe Bugla
2007-05-26 21:58                                             ` Michael Buesch
2007-05-26 19:04                       ` Michael Buesch
2007-05-28 12:12                       ` Michael Buesch
2007-05-26 16:14                     ` Uwe Bugla
2007-05-26 22:42                   ` David Miller
2007-05-25 16:56         ` Andrew Morton
2007-05-25 18:42           ` Uwe Bugla
2007-05-27 20:02 ` Denis Vlasenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox