From: Krzysztof Kozlowski <krzk@kernel.org>
To: niravkumar.l.rabara@intel.com,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: nirav.rabara@altera.com, devicetree@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: cadence: document required clock-names
Date: Wed, 12 Feb 2025 11:52:33 +0100 [thread overview]
Message-ID: <9797d470-346f-4244-ae8d-2db68ef071a6@kernel.org> (raw)
In-Reply-To: <20250212095407.2667743-2-niravkumar.l.rabara@intel.com>
On 12/02/2025 10:54, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>
> The clock-names property is required because the driver requests
> the clock by name and not the index.
> Update the example to use &clk instead of &nf_clk for the clocks
> property to avoid confusion with the clock-names property "nf_clk".
>
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> ---
> Documentation/devicetree/bindings/mtd/cdns,hp-nfc.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Please add fixes tag - probably the conversion, because original TXT
binding mentioned "nf_clk" so it could be implied.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-12 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 9:54 [PATCH v2 0/2] add clock-names property to nand node niravkumar.l.rabara
2025-02-12 9:54 ` [PATCH v2 1/2] dt-bindings: mtd: cadence: document required clock-names niravkumar.l.rabara
2025-02-12 10:52 ` Krzysztof Kozlowski [this message]
2025-02-12 9:54 ` [PATCH v2 2/2] arm64: dts: socfpga: agilex5: add clock-names property to nand node niravkumar.l.rabara
2025-02-12 10:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9797d470-346f-4244-ae8d-2db68ef071a6@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=nirav.rabara@altera.com \
--cc=niravkumar.l.rabara@intel.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox