From: Mario Limonciello <superm1@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "open list : PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list : USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
"Daniel Drake" <drake@endlessos.org>, "Gary Li" <Gary.Li@amd.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mario Limonciello" <mario.limonciello@amd.com>
Subject: Re: [PATCH] x86/tsc: Use rdtsc_ordered() when RDTSCP or LFENCE_RDTSC are supported
Date: Sun, 25 Aug 2024 07:37:45 -0500 [thread overview]
Message-ID: <979c3fc3-33d3-49fa-af80-52ec09325a08@kernel.org> (raw)
In-Reply-To: <8734msg5ce.ffs@tglx>
On 8/25/24 07:22, Thomas Gleixner wrote:
> On Thu, Aug 22 2024 at 23:25, Mario Limonciello wrote:
>
> Why is this hidden in a reply to the middle of a PCI patch series?
>
> Sigh.
As I mentioned in my reply I didn't mean for this to go out at this
time. Sorry for the noise!
It's still under testing that it REALLY helps things.
It was in my working directory and I totally missed it when I sent this
PCI series.
>
>> From: Mario Limonciello <mario.limonciello@amd.com>
>>
>> On AMD processors the TSC has been reported drifting on and off for
>> various platforms. This has been root caused to becaused by out of order
>> TSC and HPET counter values. When the SoC supports RDTSCP or LFENCE_RDTSC
>> use ordered tsc reads instead.
>
> This really wants a fixes tag.
Yes; assuming it really helps I will send it properly with tags and to
the right lists.
next prev parent reply other threads:[~2024-08-25 12:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 4:25 [PATCH v4 0/5] Verify devices transition from D3cold to D0 Mario Limonciello
2024-08-23 4:25 ` [PATCH v4 1/5] PCI: Use an enum for reset type in pci_dev_wait() Mario Limonciello
2024-08-23 11:56 ` Ilpo Järvinen
2024-08-23 4:25 ` [PATCH] x86/tsc: Use rdtsc_ordered() when RDTSCP or LFENCE_RDTSC are supported Mario Limonciello
2024-08-23 4:29 ` Mario Limonciello
2024-08-25 12:22 ` Thomas Gleixner
2024-08-25 12:37 ` Mario Limonciello [this message]
2024-08-23 4:25 ` [PATCH v4 2/5] PCI: Check PCI_PM_CTRL instead of PCI_COMMAND in pci_dev_wait() Mario Limonciello
2024-08-23 12:13 ` Ilpo Järvinen
2024-08-23 4:25 ` [PATCH v4 3/5] PCI: Verify functions currently in D3cold have entered D0 Mario Limonciello
2024-08-23 12:07 ` Ilpo Järvinen
2024-08-23 4:25 ` [PATCH v4 4/5] PCI: Allow Ryzen XHCI controllers into D3cold and drop delays Mario Limonciello
2024-08-24 1:55 ` Greg Kroah-Hartman
2024-08-23 4:25 ` [PATCH v4 5/5] PCI: Drop Radeon quirk for Macbook Pro 8.2 Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=979c3fc3-33d3-49fa-af80-52ec09325a08@kernel.org \
--to=superm1@kernel.org \
--cc=Gary.Li@amd.com \
--cc=bhelgaas@google.com \
--cc=drake@endlessos.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mathias.nyman@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox