From: Niklas Schnelle <schnelle@linux.ibm.com>
To: "Lukas Wunner" <lukas@wunner.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Niklas Schnelle <niks@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Rob Herring <robh@kernel.org>,
Krzysztof Wilczy??ski <kw@linux.com>,
"Maciej W . Rozycki" <macro@orcam.me.uk>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Alexandru Gagniuc <mr.nuke.me@gmail.com>,
Krishna chaitanya chundru <quic_krichai@quicinc.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org,
Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] PCI/portdrv: Disable bwctrl service if port is fixed at 2.5 GT/s
Date: Thu, 12 Dec 2024 10:17:21 +0100 [thread overview]
Message-ID: <97bbbdecb8c65cfa2625b47aa2585a7417ddcb81.camel@linux.ibm.com> (raw)
In-Reply-To: <Z1qoDmF6urJDN5jh@wunner.de>
On Thu, 2024-12-12 at 10:08 +0100, Lukas Wunner wrote:
> On Wed, Dec 11, 2024 at 03:07:38PM +0200, Ilpo Järvinen wrote:
> > I recall taking note of this inconsistency in some lspci dumps I've from
> > Mika (but forgot it until now). So I'm afraid it might be more widespread
> > than just TR.
>
> Oh you did? Interesting. After re-reading the spec I'm convinced now
> that we're doing this wrong and that we should honor the Max Link Speed
> instead of blindly deeming all set bits in the Link Capabilities 2
> Register as supported speeds:
>
> https://lore.kernel.org/r/e3386d62a766be6d0ef7138a001dabfe563cdff8.1733991971.git.lukas@wunner.de/
>
> @Niklas, could you test if this is sufficient to avoid the issue?
> Or do we still need to stop instantiating the bandwidth controller
> if more than one speed is supported?
>
> Thanks!
>
> Lukas
Yes, I will test this but will only get to do so tonight (UTC +2). If
it's not sufficient I think we could use the modified
pcie_get_supported_speeds() to check if only one link speed is
supported, right?
Thanks,
Niklas
next prev parent reply other threads:[~2024-12-12 9:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-07 18:44 [PATCH] PCI/portdrv: Disable bwctrl service if port is fixed at 2.5 GT/s Niklas Schnelle
2024-12-07 19:12 ` Niklas Schnelle
2024-12-09 12:59 ` Ilpo Järvinen
2024-12-09 15:42 ` Mika Westerberg
2024-12-10 10:05 ` Lukas Wunner
2024-12-10 20:45 ` Niklas Schnelle
2024-12-11 7:57 ` Lukas Wunner
2024-12-11 13:07 ` Ilpo Järvinen
2024-12-12 9:08 ` Lukas Wunner
2024-12-12 9:17 ` Niklas Schnelle [this message]
2024-12-12 12:32 ` Lukas Wunner
2024-12-12 14:12 ` Niklas Schnelle
2024-12-12 20:40 ` Niklas Schnelle
2024-12-13 8:37 ` Lukas Wunner
2024-12-16 6:57 ` Mika Westerberg
2024-12-11 17:14 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97bbbdecb8c65cfa2625b47aa2585a7417ddcb81.camel@linux.ibm.com \
--to=schnelle@linux.ibm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=amitk@kernel.org \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel.lezcano@linaro.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=mika.westerberg@linux.intel.com \
--cc=mr.nuke.me@gmail.com \
--cc=niks@kernel.org \
--cc=quic_krichai@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox