Re: [PATCH bpf-next v3 3/6] bpf: fix the usage of BPF_TRAMP_F_SKIP_FRAME

Menglong Dong
2025-12-19T14:54:41Z

On Fri, Dec 19, 2025 at 10:50 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Dez 19 2025, Menglong Dong wrote:
>
> > @@ -1171,6 +1167,8 @@ static int __arch_prepare_bpf_trampoline(struct
> > bpf_tramp_image *im,
> > }
> >
> > if (flags & BPF_TRAMP_F_CALL_ORIG) {
> > + /* skip to actual body of traced function */
> > + orig_call += RV_FENTRY_NINSNS * 4;
>
> Before this line, orig_call still contains the same value as func_addr,
> with the latter being dead, so there is not much point in using a copy.

Yeah, we can use "func_addr + RV_FENTRY_NINSNS * 4" here directly.

>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."