Re: [PATCH] arm64: dts: cix: Use lowercase hex

[Krzysztof Kozlowski <krzk@kernel.org>]

On 30/12/2025 03:05, Peter Chen wrote:
> On 25-12-29 08:17:15, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL
>>
>> On 29/12/2025 02:40, Peter Chen wrote:
>>> On 25-12-23 16:24:25, Krzysztof Kozlowski wrote:
>>>> EXTERNAL EMAIL
>>>>
>>>> The DTS code coding style expects lowercase hex for values and unit
>>>> addresses.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>>>
>>>> ---
>>>>
>>>> Patches done with sed, verified with comparing unflattened DTB and
>>>> dtx_diff.
>>>> ---
>>>>  arch/arm64/boot/dts/cix/sky1.dtsi | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi
>>>> index 64b76905cbff..fb8c826bbc97 100644
>>>> --- a/arch/arm64/boot/dts/cix/sky1.dtsi
>>>> +++ b/arch/arm64/boot/dts/cix/sky1.dtsi
>>>> @@ -523,7 +523,7 @@ pcie_x1_1_rc: pcie@a0e0000 {
>>>>                         reg-names = "reg", "cfg", "rcsu_strap", "rcsu_status", "msg";
>>>>                         ranges = <0x01000000 0x0 0x38100000 0x0 0x38100000 0x0 0x00100000>,
>>>>                                  <0x02000000 0x0 0x38200000 0x0 0x38200000 0x0 0x07e00000>,
>>>> -                                <0x43000000 0x0C 0x00000000 0x0C 0x00000000 0x04 0x00000000>;
>>>> +                                <0x43000000 0x0c 0x00000000 0x0c 0x00000000 0x04 0x00000000>;
>>>
>>> Sorry, I could not apply for v6.19-rc1, could you?
>>
>> What do you mean? It applies cleanly on v6.19-rc1 and on next. Your
>> branches are not really updated, so maybe you need to fix this.
>>
> 
> Sorry for confusing. The patch was inserted by some special characters,
> See below: "=", and "3D". But no these kinds of characters when I save
> internal patch for upstream. Our IT is checking this issue.

The patch does not have them. It must have been your email system, which
broke it or you did not save it correctly. I suggest to apply patches
with b4, see my talk from LPC 2023 - Beginner Linux kernel maintainer's
toolbox.


Best regards,
Krzysztof