From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754584Ab0IOPmk (ORCPT ); Wed, 15 Sep 2010 11:42:40 -0400 Received: from lennier.cc.vt.edu ([198.82.162.213]:41363 "EHLO lennier.cc.vt.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677Ab0IOPmg (ORCPT ); Wed, 15 Sep 2010 11:42:36 -0400 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Al Viro , Christoph Hellwig , David Airlie , dri-devel@lists.freedesktop.org, Jeremy Kerr , "John W. Linville" , Julia Lawall , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Samuel Ortiz , Stephen Rothwell , Tony Lindgren Subject: Re: [PATCH 00/15] change default_llseek action In-Reply-To: Your message of "Tue, 14 Sep 2010 22:22:28 +0200." <1284495763-7506-1-git-send-email-arnd@arndb.de> From: Valdis.Kletnieks@vt.edu References: <1284495763-7506-1-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1284565136_4463P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Wed, 15 Sep 2010 11:38:56 -0400 Message-ID: <9828.1284565136@localhost> X-Mirapoint-Received-SPF: 128.173.14.107 localhost Valdis.Kletnieks@vt.edu 2 pass X-Mirapoint-IP-Reputation: reputation=neutral-1, source=Fixed, refid=n/a, actions=MAILHURDLE SPF TAG X-Junkmail-Status: score=10/50, host=vivi.cc.vt.edu X-Junkmail-SD-Raw: score=unknown, refid=str=0001.0A020208.4C90E891.03BC,ss=1,fgs=0, ip=0.0.0.0, so=2009-09-22 00:05:22, dmn=2009-09-10 00:05:08, mode=single engine X-Junkmail-IWF: false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --==_Exmh_1284565136_4463P Content-Type: text/plain; charset=us-ascii On Tue, 14 Sep 2010 22:22:28 +0200, Arnd Bergmann said: > This changes *all* instances of struct file_operations in > the kernel to have a .llseek operation and then changes > the default to no_llseek, which returns -ESPIPE, which > is what we had decided some time ago in a discussion > with Christoph Hellwig. I don't suppose there's any clean way to throw a build error or a printk_on_once() or something if we encounter an unconverted 'struct file_operations', is there? I have this creeping fear that this patch will go upstream during the merge window - as will 12 new staging/ drivers from authors who didn't get the memo yet. Other than the "missed converting a new usage" issue, it looks OK to me. --==_Exmh_1284565136_4463P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Exmh version 2.5 07/13/2001 iD8DBQFMkOiQcC3lWbTT17ARAqwmAKDtt7WLCtHcS+CHyD0HhQqZdVYOywCgg7fS U3JZpm40giJnTm/uyS6JlMA= =9mVq -----END PGP SIGNATURE----- --==_Exmh_1284565136_4463P--