From: Adrian Hunter <adrian.hunter@intel.com>
To: Victor Shih <victorshihgli@gmail.com>, ulf.hansson@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
benchuanggli@gmail.com, HL.Liu@genesyslogic.com.tw,
Greg.tu@genesyslogic.com.tw, takahiro.akashi@linaro.org,
dlunev@chromium.org,
Victor Shih <victor.shih@genesyslogic.com.tw>,
Ben Chuang <ben.chuang@genesyslogic.com.tw>
Subject: Re: [PATCH V6 22/24] mmc: sdhci-uhs2: add post-mmc_attach_sd hook
Date: Thu, 5 Jan 2023 23:31:09 +0200 [thread overview]
Message-ID: <9841589c-757e-ea01-0c55-abe4a38fae03@intel.com> (raw)
In-Reply-To: <20221213090047.3805-23-victor.shih@genesyslogic.com.tw>
On 13/12/22 11:00, Victor Shih wrote:
> From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
>
> This "post" hook for mmc_attach_sd(), uhs2_post_attach_sd, will be required
> to enable UHS-II support, at least, on GL9755.
>
> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> drivers/mmc/host/sdhci.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index e5f64b38e339..4aac22b58d79 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -728,6 +728,7 @@ struct sdhci_ops {
> void (*dump_vendor_regs)(struct sdhci_host *host);
> void (*dump_uhs2_regs)(struct sdhci_host *host);
> void (*uhs2_pre_detect_init)(struct sdhci_host *host);
> + void (*uhs2_post_attach_sd)(struct sdhci_host *host);
This gets called already in "mmc: sdhci-uhs2: add uhs2_control()
to initialise the interface"
Either move that line to this patch or vice versa.
Please check compiling after each patch is applied.
> };
>
> #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS
next prev parent reply other threads:[~2023-01-05 21:32 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 9:00 [PATCH V6 00/24] Add support UHS-II for GL9755 Victor Shih
2022-12-13 9:00 ` [PATCH V6 01/24] mmc: core: Cleanup printing of speed mode at card insertion Victor Shih
2023-01-05 21:22 ` Adrian Hunter
2023-02-24 10:22 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 02/24] mmc: core: Prepare to support SD UHS-II cards Victor Shih
2022-12-13 9:00 ` [PATCH V6 03/24] mmc: core: Announce successful insertion of an SD UHS-II card Victor Shih
2022-12-13 9:00 ` [PATCH V6 04/24] mmc: core: Extend support for mmc regulators with a vqmmc2 Victor Shih
2022-12-13 9:00 ` [PATCH V6 05/24] mmc: core: Add definitions for SD UHS-II cards Victor Shih
2023-02-06 16:13 ` Ulf Hansson
2023-02-24 10:23 ` Victor Shih
2023-02-27 15:29 ` Ulf Hansson
2023-02-07 10:59 ` Ulf Hansson
2022-12-13 9:00 ` [PATCH V6 06/24] mmc: core: Support UHS-II card control and access Victor Shih
2023-01-05 21:26 ` Adrian Hunter
2023-02-08 15:30 ` Ulf Hansson
2023-02-24 10:23 ` Victor Shih
2023-02-27 15:19 ` Ulf Hansson
2022-12-13 9:00 ` [PATCH V6 07/24] mmc: sdhci: add UHS-II related definitions in headers Victor Shih
2023-01-05 21:22 ` Adrian Hunter
2023-02-24 10:22 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 08/24] mmc: sdhci: add UHS-II module and add a kernel configuration Victor Shih
2022-12-13 9:00 ` [PATCH V6 09/24] mmc: sdhci-uhs2: dump UHS-II registers Victor Shih
2023-01-05 21:26 ` Adrian Hunter
2023-02-24 10:22 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 10/24] mmc: sdhci-uhs2: add reset function and uhs2_mode function Victor Shih
2022-12-13 9:00 ` [PATCH V6 11/24] mmc: sdhci-uhs2: add set_power() to support vdd2 Victor Shih
2023-01-05 21:27 ` Adrian Hunter
2023-02-24 10:22 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 12/24] mmc: sdhci-uhs2: skip signal_voltage_switch() Victor Shih
2022-12-13 9:00 ` [PATCH V6 13/24] mmc: sdhci-uhs2: add set_timeout() Victor Shih
2022-12-13 9:00 ` [PATCH V6 14/24] mmc: sdhci-uhs2: add set_ios() Victor Shih
2023-01-05 21:27 ` Adrian Hunter
2023-01-26 10:58 ` Victor Shih
2023-01-30 13:16 ` Adrian Hunter
2023-02-24 10:23 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 15/24] mmc: sdhci-uhs2: add detect_init() to detect the interface Victor Shih
2023-01-05 21:28 ` Adrian Hunter
2023-02-24 10:22 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 16/24] mmc: sdhci-uhs2: add clock operations Victor Shih
2022-12-13 9:00 ` [PATCH V6 17/24] mmc: sdhci-uhs2: add uhs2_control() to initialise the interface Victor Shih
2023-01-05 21:28 ` Adrian Hunter
2023-02-24 10:22 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 18/24] mmc: sdhci-uhs2: add request() and others Victor Shih
2023-01-05 21:29 ` Adrian Hunter
2023-02-24 10:22 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 19/24] mmc: sdhci-uhs2: add irq() " Victor Shih
2023-01-05 21:30 ` Adrian Hunter
2023-02-24 10:22 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 20/24] mmc: sdhci-uhs2: add add_host() and others to set up the driver Victor Shih
2023-01-05 21:30 ` Adrian Hunter
2023-02-24 10:23 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 21/24] mmc: sdhci-uhs2: add pre-detect_init hook Victor Shih
2022-12-13 9:00 ` [PATCH V6 22/24] mmc: sdhci-uhs2: add post-mmc_attach_sd hook Victor Shih
2023-01-05 21:31 ` Adrian Hunter [this message]
2023-02-24 10:23 ` Victor Shih
2022-12-13 9:00 ` [PATCH V6 23/24] mmc: sdhci-pci: add UHS-II support framework Victor Shih
2022-12-13 9:00 ` [PATCH V6 24/24] mmc: sdhci-pci-gli: enable UHS-II mode for GL9755 Victor Shih
2023-02-08 11:35 ` Ulf Hansson
2023-01-03 11:04 ` [PATCH V6 00/24] Add support UHS-II " Victor Shih
2023-01-03 11:47 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9841589c-757e-ea01-0c55-abe4a38fae03@intel.com \
--to=adrian.hunter@intel.com \
--cc=Greg.tu@genesyslogic.com.tw \
--cc=HL.Liu@genesyslogic.com.tw \
--cc=ben.chuang@genesyslogic.com.tw \
--cc=benchuanggli@gmail.com \
--cc=dlunev@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=takahiro.akashi@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=victor.shih@genesyslogic.com.tw \
--cc=victorshihgli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox