Re: [PATCH] Version 3 (2.6.23-rc8) Smack: Simplified Mandatory Access Control Kernel

[Casey Schaufler <casey@schaufler-ca.com>]

--- Andi Kleen <ak@suse.de> wrote:

> 
> > - Smack.txt and the website seem a bit skimpy.  Is there enough
> >   documentation out there for someone to usefully (and, more importantly,
> >   safely) start using smack?
> 
> Yes that's the important thing.
> 
> > - In his review of version 1, Andi suggested that your ruleset traversal
> >   be protected by RCU.  But it seems that this wasn't done.  Were the races
> >   which he identified fixed by other means?  If so, what were they?
> 
> The issue was moot because rulesets never get removed in the current 
> implementation. I had missed that. If that ever changes RCU would be likely 
> needed though.
> 
> > - hm, netlabels.  Who might be a suitable person to review that code?
> >   Seems that Paul Moore is the man.  Maybe he'd be interested in taking a
> >   look over it (please?)
> 
> I personally consider these IP options it uses to be pretty useless. Who
> could 
> ever use that without cryptographic authentication? Clearly when they 
> were designed in the original IP spec long ago the designers didn't
> understand
> network security very well because the whole field was at its infancy. And 
> CIPSO doesn't solve any of these fundamental issues.

Real quickly, CIPSO doesn't try to. CIPSO attaches attribute information
to the packet, and that's it. Smack uses CIPSO because it's available
and sufficient to get the required information about packets from one
task to another inside the box. It does the job going off box, too.
The authentication issues are very real, but a separate issue.

> It assumes a trusted network which is a very dangerous assumption.  I don't 
> think that was in the original patch I looked at, I surely would have 
> objected to it.
>
> Perhaps take the network part out? I guess SMACK would be useful
> locally even without questionable network support.

That would break sockets. I really doubt that you're suggesting that
cryptographic authentication is required on the loopback interface.


Casey Schaufler
casey@schaufler-ca.com